test: fix test-tls-client-mindhsize for OpenSSL32#54739
Closed
mhdawson wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
added
needs-ci
Member
Author
|
Run on OpenSSL32 - https://ci.nodejs.org/job/richardlau-node-test-commit-linux-containered/40/ |
richardlau
approved these changes
Sep 3, 2024
lpinca
approved these changes
Sep 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54739 +/- ##
==========================================
- Coverage 88.06% 88.06% -0.01%
==========================================
Files 651 651
Lines 183386 183386
Branches 35800 35796 -4
==========================================
- Hits 161504 161491 -13
- Misses 15159 15162 +3
- Partials 6723 6733 +10 |
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Sep 5, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
This PR is currently blocked from landing due to unreliable CI. |
Member
Author
|
@jasnell was going to rebase and try again as I'd seen some PRs mark more tests as flaky. |
mhdawson
force-pushed
the
increase-dh-sizes-for-openssl21
branch
from
104de8a to
1a1f9ab
Compare
Member
Author
|
Rebased hoping to get more PRs where tests were marked as flaky |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
Bot
removed
the
request-ci
Member
Author
|
rebased again as tests that were failing were already marked as flaky. |
Collaborator
github-actions
Bot
removed
the
request-ci
Collaborator
mhdawson
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/54739 ✔ Done loading data for nodejs/node/pull/54739 ----------------------------------- PR info ------------------------------------ Title test: fix test-tls-client-mindhsize for OpenSSL32 (#54739) Author Michael Dawson <midawson@redhat.com> (@mhdawson) Branch mhdawson:increase-dh-sizes-for-openssl21 -> nodejs:main Labels test, needs-ci Commits 1 - test: fix test-tls-client-mindhsize for OpenSSL32 Committers 1 - Michael Dawson <midawson@redhat.com> PR-URL: https://github.com/nodejs/node/pull/54739 Refs: https://github.com/nodejs/node/issues/53382 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54739 Refs: https://github.com/nodejs/node/issues/53382 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - test: fix test-tls-client-mindhsize for OpenSSL32 ℹ This PR was created on Tue, 03 Sep 2024 16:32:09 GMT ✔ Approvals: 3 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/54739#pullrequestreview-2277959625 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54739#pullrequestreview-2277994160 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54739#pullrequestreview-2283639489 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-09-11T18:38:03Z: https://ci.nodejs.org/job/node-test-pull-request/62337/ - Querying data for job/node-test-pull-request/62337/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10823337922 |
jasnell
pushed a commit
that referenced
this pull request
Sep 12, 2024
Refs: #53382 - OpenSSL32 has a minimum dh key size by 2048 by default. - Create larter 3072 dh key needed for testing and adjust tests to use it for builds with OpenSSL32 Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #54739 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in d9ca8b0 |
Refs: #53382