Skip to content

build: update main branch name in GH workflow#43481

Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
F3n67u:main-workflow
Jun 23, 2022
Merged

build: update main branch name in GH workflow#43481
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
F3n67u:main-workflow

Conversation

@F3n67u
Copy link
Copy Markdown
Contributor

@F3n67u F3n67u commented Jun 19, 2022

Refs: #33864

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jun 19, 2022

Review requested:

  • @nodejs/actions

@F3n67u F3n67u requested review from RaisinTen and aduh95 June 19, 2022 03:01
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 19, 2022
F3n67u
F3n67u commented Jun 19, 2022
View reviewed changes
Comment thread .github/workflows/linters.yml Outdated
aduh95
aduh95 reviewed Jun 19, 2022
View reviewed changes
Comment thread .github/workflows/build-tarball.yml Outdated
F3n67u and others added 2 commits June 19, 2022 16:04
@F3n67u
Revert "squash: use $default-branch macro rather than hardcoded main"
afc34f3 
This reverts commit 5b036a8.
@F3n67u @aduh95
Update .github/workflows/linters.yml
0d21cf6 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
targos reviewed Jun 19, 2022
View reviewed changes
Comment thread .github/workflows/linters.yml Outdated
@F3n67u @aduh95
Update .github/workflows/linters.yml
6358639 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@F3n67u
Copy link
Copy Markdown
Contributor Author

F3n67u commented Jun 19, 2022

@aduh95 I made a mistake, it is github.event.repository.default_branch , not github.repository.default_branch. The format-cpp will not run when pull request if use github.repository.default_branch.

I pushed a new commit to fix this problem: 4f3386a

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 19, 2022
RaisinTen
RaisinTen approved these changes Jun 20, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@F3n67u
Copy link
Copy Markdown
Contributor Author

F3n67u commented Jun 22, 2022

Hey folks. could you help to land this pr please？the format-cpp check is not run for all pr into main, I am worried about it would introduce some cpp format problem to main.

juanarbol
juanarbol approved these changes Jun 23, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RaisinTen RaisinTen added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 23, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 23, 2022
@nodejs-github-bot nodejs-github-bot merged commit 6f924ac into nodejs:main Jun 23, 2022
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jun 23, 2022

Landed in 6f924ac

@F3n67u F3n67u deleted the main-workflow branch June 23, 2022 05:09
@F3n67u
Copy link
Copy Markdown
Contributor Author

F3n67u commented Jun 23, 2022

Thank you.

F3n67u added a commit to F3n67u/node that referenced this pull request Jun 24, 2022
@F3n67u
build: update main branch name in GH workflow
e6ebef3 
PR-URL: nodejs#43481
Refs: nodejs#33864
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
targos pushed a commit that referenced this pull request Jul 12, 2022
@F3n67u @targos
build: update main branch name in GH workflow
919c5ee 
PR-URL: #43481
Refs: #33864
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
@targos targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022