Skip to content

perf_hooks: add PerformanceResourceTiming#42725

Closed
RafaelGSS wants to merge 1 commit into
nodejs:masterfrom
RafaelGSS:perf_hooks/resource-timing
Closed

perf_hooks: add PerformanceResourceTiming#42725
RafaelGSS wants to merge 1 commit into
nodejs:masterfrom
RafaelGSS:perf_hooks/resource-timing

Conversation

@RafaelGSS
Copy link
Copy Markdown
Member

@RafaelGSS RafaelGSS commented Apr 13, 2022 •
edited
Loading

Fixes: nodejs/undici#952

I'm opening it as a draft to get some feedback from the comments I added to the code that is unclear to me reading the W3C Spec.

This PR contains the implementation of:

EDIT1: Moving it to ready-to-review. I'll add a few questions inlined in the review.

@RafaelGSS RafaelGSS requested review from Qard, jasnell and ronag April 13, 2022 19:52
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. labels Apr 13, 2022
@RafaelGSS RafaelGSS requested a review from mcollina April 15, 2022 03:10
@RafaelGSS RafaelGSS force-pushed the perf_hooks/resource-timing branch 2 times, most recently from 16c6250 to e23178d Compare April 16, 2022 04:45
@RafaelGSS RafaelGSS marked this pull request as ready for review April 16, 2022 04:46
RafaelGSS
RafaelGSS commented Apr 16, 2022
View reviewed changes
Comment thread lib/internal/perf/resource_timing.js
RafaelGSS
RafaelGSS commented Apr 16, 2022
View reviewed changes
Comment thread lib/internal/perf/performance.js
@RafaelGSS RafaelGSS force-pushed the perf_hooks/resource-timing branch from e23178d to bfa9754 Compare April 20, 2022 10:42
ronag
ronag approved these changes Apr 20, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@ronag ronag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@RafaelGSS RafaelGSS force-pushed the perf_hooks/resource-timing branch from fc94f0d to 4904cc8 Compare April 20, 2022 11:16
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 20, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43595/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 20, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43598/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 20, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43602/

@github-actions github-actions Bot mentioned this pull request Apr 21, 2022
Open
22 tasks
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 21, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43614/

@github-actions github-actions Bot mentioned this pull request Apr 22, 2022
Open
19 tasks
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 22, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43635/

@RafaelGSS
Copy link
Copy Markdown
Member Author

RafaelGSS commented Apr 22, 2022

It keeps failing in windows compilation vs2019-x86 and there is no output as far I can see. Any clue?

@richardlau
Copy link
Copy Markdown
Member

richardlau commented Apr 22, 2022

It keeps failing in windows compilation vs2019-x86 and there is no output as far I can see. Any clue?

You need to pick up the latest V8 update from #42740. Try starting a fresh CI (not resuming). If that doesn't work you may have to rebase this on top of current master.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 22, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43640/

@github-actions github-actions Bot mentioned this pull request Apr 23, 2022
Open
21 tasks
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 23, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43649/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 23, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43651/

@RafaelGSS RafaelGSS force-pushed the perf_hooks/resource-timing branch from 4904cc8 to 2173e92 Compare April 23, 2022 16:01
@github-actions github-actions Bot mentioned this pull request May 16, 2022
Open
25 tasks
BethGriggs pushed a commit that referenced this pull request May 16, 2022
@RafaelGSS @BethGriggs
perf_hooks: add PerformanceResourceTiming
c92e291 
perf_hooks: create clearResourceTimings

perf_hooks: add resourcetiming test parallel

perf_hooks: add markResourceTiming

perf_hooks: fix observable when using resource

perf_hooks: fix observable when using resource

perf_hooks: add class comments

perf_hooks: add PerformanceResourceTiming

perf_hooks: create clearResourceTimings

perf_hooks: add resourcetiming test parallel

perf_hooks: add markResourceTiming

perf_hooks: fix observable when using resource

perf_hooks: fix observable when using resource

perf_hooks: add class comments

perf_hooks: add Resource Timing documentation

benchmark: measure resource timing module

perf_hooks: add check avoiding new PerformanceResourceTiming

perf_hooks: adjust doc

PR-URL: #42725
Fixes: nodejs/undici#952
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request May 16, 2022
Merged
RafaelGSS added a commit that referenced this pull request May 16, 2022
@RafaelGSS
2022-05-17, Version 18.2.0 (Current)
2e84c93 
Notable changes:

* This release updates OpenSSL to 3.0.3.
This update can be treated as a security release as the issues addressed in OpenSSL 3.0.3 slightly affect Node.js 18.
See https://nodejs.org/en/blog/vulnerability/openssl-fixes-in-regular-releases-may2022/ for more information on how the May 2022 OpenSSL releases affect other Node.js release lines.

* *Revert*_ "deps: add template for generated headers" (Daniel Bevenius)