Skip to content

worker: set trackUnmanagedFds to true by default#34394

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:worker-track-unmanaged-flip-default
Closed

worker: set trackUnmanagedFds to true by default#34394
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:worker-track-unmanaged-flip-default

Conversation

@addaleax
Copy link
Copy Markdown
Member

@addaleax addaleax commented Jul 16, 2020

This prevents accidental resource leaks when terminating or exiting
Worker that own FDs opened through fs.open().

Refs: #34303

@nodejs/workers

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the worker Issues and PRs related to Worker support. label Jul 16, 2020
@addaleax addaleax force-pushed the worker-track-unmanaged-flip-default branch 2 times, most recently from 45d72bc to 50fd5a3 Compare July 16, 2020 12:41
benjamingr
benjamingr reviewed Jul 16, 2020
View reviewed changes
Comment thread lib/internal/worker.js Outdated
@addaleax addaleax added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 16, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 20, 2020
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jul 20, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32418/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jul 20, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32429/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jul 21, 2020 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/32448/ (:green_heart:)

@addaleax addaleax force-pushed the worker-track-unmanaged-flip-default branch from e1adba0 to 8c26de2 Compare July 21, 2020 23:45
@addaleax
worker: set trackUnmanagedFds to true by default
d48c223 
This prevents accidental resource leaks when terminating or exiting
Worker that own FDs opened through `fs.open()`.

Refs: nodejs#34303
@addaleax addaleax force-pushed the worker-track-unmanaged-flip-default branch from 8c26de2 to d48c223 Compare July 21, 2020 23:46
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jul 21, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32461/

@github-actions github-actions Bot mentioned this pull request Jul 22, 2020
Open
5 tasks
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jul 22, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32473/

jasnell pushed a commit that referenced this pull request Jul 22, 2020
@addaleax @jasnell
worker: set trackUnmanagedFds to true by default
7603c7e 
This prevents accidental resource leaks when terminating or exiting
Worker that own FDs opened through `fs.open()`.

Refs: #34303

PR-URL: #34394
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@jasnell
Copy link
Copy Markdown
Member

jasnell commented Jul 22, 2020

Landed in 7603c7e

@jasnell jasnell closed this Jul 22, 2020
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@addaleax @cjihrig
worker: set trackUnmanagedFds to true by default
9b353c6 
This prevents accidental resource leaks when terminating or exiting
Worker that own FDs opened through `fs.open()`.

Refs: #34303

PR-URL: #34394
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This was referenced Jul 23, 2020
Open
Open
Open
Open
Open
This was referenced Jul 28, 2020
Open
Open
Open
Open
Open
@BethGriggs BethGriggs mentioned this pull request Sep 1, 2020
Merged
BethGriggs added a commit that referenced this pull request Oct 19, 2020
@BethGriggs