events: deal with no argument case

[benjamingr]

Fix new Event() to throw an error rather than behave like new Event(undefined) to align with browser behavior.

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

cc @jasnell

I'll be making a few of these (compatibility) PRs to align with Chrome's behavior as I run into issues and eventually port the WPTs (as suggested by @targos).

I'm keeping these small so it's easier to bikeshed things like error codes.

[benjamingr]

@targos is this more of what you had in mind?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/31613/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/31615/

[benjamingr]

Landed in 8ae28ff

@BridgeAR thanks for the help landing things with ncu - please take a look and make sure I didn't dum-goofed :]

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/31677/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/31685/

[jasnell]

@benjamingr ... the CI failure here can be fixed with the following change:

diff --git a/test/parallel/test-eventtarget.js b/test/parallel/test-eventtarget.js
index 82a89caae1..783ca5eeab 100644
--- a/test/parallel/test-eventtarget.js
+++ b/test/parallel/test-eventtarget.js
@@ -408,6 +408,6 @@ ok(EventTarget);
 {
   const target = new EventTarget();
   strictEqual(target.toString(), '[object EventTarget]');
-  const event = new Event();
+  const event = new Event('');
   strictEqual(event.toString(), '[object Event]');
 }

[benjamingr]

@jasnell pushed a fix, feel free to push such fixed on my (ET) branches in the future and thanks for landing.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/31718/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/31720/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/31721/