Skip to content

Italian Translation#556

Merged
lissy93 merged 1 commit into
lissy93:masterfrom
alexdelprete:master
Mar 13, 2022
Merged

Italian Translation#556
lissy93 merged 1 commit into
lissy93:masterfrom
alexdelprete:master

Conversation

@alexdelprete
Copy link
Copy Markdown
Contributor

@alexdelprete alexdelprete commented Mar 13, 2022

alexdelprete Medium alexdelprete /master → Lissy93/dashy Commits: 1 | Files Changed: 2 | Additions: 123 Quality Checklist Label

Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category:
Localization

Overview
Updated and Completed Italian Translation and corrected a minor mistake in the english translation (1 word).

@alexdelprete alexdelprete requested a review from lissy93 as a code owner March 13, 2022 18:15
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 13, 2022

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: b1ed8c4

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/622e34bc1670920008678c8c

😎 Browse the preview: https://deploy-preview-556--dashy-dev.netlify.app/

@viezly
Copy link
Copy Markdown

viezly Bot commented Mar 13, 2022

Changes preview:

Legend:

👀 Review pull request on Viezly

Copy link
Copy Markdown
Owner

@lissy93 lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks very much :)

@lissy93 lissy93 merged commit eae4349 into lissy93:master Mar 13, 2022
@alexdelprete
Copy link
Copy Markdown
Contributor Author

We need to thank you for the development of Dashy: you've made a fantastic job. Happy to help just a tiny bit. :)

BTW: in the en.json file, I translated the two last sections, but I had the feeling they were there by mistake (airlines?):

    "flight-data": {
      "arrivals": "Arrivals",
      "departures": "Departures"
    },
    "tfl-status": {
      "good-service-all": "Good Service on all Lines",
      "good-service-rest": "Good Service on all other Lines"
    }

@lissy93
Copy link
Copy Markdown
Owner

lissy93 commented Mar 13, 2022

Thank you for your kind words, very glad you're enjoying it :)

Those last two translations are used by widgets,- I think the Flight data and Train status widgets

@alexdelprete
Copy link
Copy Markdown
Contributor Author

Those last two translations are used by widgets,- I think the Flight data and Train status widgets

Incredible, I didn't even know there were widgets (still reading TFM) !! 🤣

Amazing work Lissy. 👏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants