Skip to content

fix: prevent render loop#1898

Merged
lissy93 merged 2 commits into
lissy93:masterfrom
vinceh121:fix/render-loop
Apr 8, 2026
Merged

fix: prevent render loop#1898
lissy93 merged 2 commits into
lissy93:masterfrom
vinceh121:fix/render-loop

Conversation

@vinceh121
Copy link
Copy Markdown
Contributor

@vinceh121 vinceh121 commented Aug 9, 2025

vinceh121 Quick vinceh121 /fix/render-loop → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 0 Label Unchecked Tasks Powered by Pull Request Badge

Category:
Bugfix

Overview
A regression was introduced that induced an infinite render-loop due to a watched config array being updated within a component render method. The array is now copied to avoid falling into this loop.

Issue Number
N/A

New Vars
N/A

Screenshot
N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • (If significant change) Bumps version in package.json

@vinceh121 vinceh121 requested a review from lissy93 as a code owner August 9, 2025 00:10
@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 9, 2025

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 118ccf1
🔍 Latest deploy log https://app.netlify.com/projects/dashy-dev/deploys/689691ebaac24e00083647d5
😎 Deploy Preview https://deploy-preview-1898--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lissy93 lissy93 merged commit 1694ae5 into lissy93:master Apr 8, 2026
1 check was pending
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 8, 2026

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit d8ed395
🔍 Latest deploy log https://app.netlify.com/projects/dashy-dev/deploys/69d60ff2e675e00008c181e9
😎 Deploy Preview https://deploy-preview-1898--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants