Skip to content

Solve background image resize#1058

Merged
lissy93 merged 2 commits into
lissy93:masterfrom
BySempron:master
Jan 29, 2023
Merged

Solve background image resize#1058
lissy93 merged 2 commits into
lissy93:masterfrom
BySempron:master

Conversation

@BySempron
Copy link
Copy Markdown
Contributor

@BySempron BySempron commented Jan 10, 2023

BySempron Quick BySempron /master → Lissy93/dashy Commits: 2 | Files Changed: 2 | Additions: 0 Label

Category: Bugfix

Overview

Fix #984

When open and closing sections, the background image resize. Added a couple of CSS keys to keep the image full screen and static.

Issue Number #984

Screenshot

Animation.webm

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@BySempron BySempron requested a review from lissy93 as a code owner January 10, 2023 19:48
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 10, 2023

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit c7c4df7
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/63d512b4e8bb6b0009a6c474
😎 Deploy Preview https://deploy-preview-1058--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link
Copy Markdown

viezly Bot commented Jan 10, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

Copy link
Copy Markdown
Owner

@lissy93 lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@lissy93 lissy93 merged commit 7080e3c into lissy93:master Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Image background moves when open/close section

2 participants