Use read-pkg-up over pkg-up.

[wtgtybhertgeghgtwtg]

Closes #675.

[wtgtybhertgeghgtwtg]

I can't seem to find why this is failing. Does anyone with more experience with rule-tester have any insight?

[jfmengels]

Hey @wtgtybhertgeghgtwtg! Thanks for the PR and sorry for the delay.

I made comments that should help you fix the tests :)

[jfmengels]

Can you remove this import, now that it is not used?

[jfmengels]

The problem that makes the build fail is that getDependencies is now returning something else. pkg.pkg is now an object, and not a string that remains to be parsed. By attempting to parse it you are causing an error, which will be cached and make the function return null.

This works better:

    const pkg = readPkgUp.sync({cwd: context.getFilename(), normalize: false})
    if (!pkg || !pkg.pkg) {
      return null
    }

    const packageContent = pkg.pkg

[wtgtybhertgeghgtwtg]

Thank you, I don't know how I missed that.

[coveralls]

Coverage remained the same at 94.86% when pulling dfc381c on wtgtybhertgeghgtwtg:master into bfdc2bb on benmosher:master.

[jfmengels]

Thanks for the changes :)

LGTM, but do you know why the whole file is considered a having been changed in that last commit, instead of only the modified lines? That's pretty odd 🤔
If possible, I would love to have only the lines that have really changed be marked as changed, for debugging purposes later on. If you feel like looking at that, that'd be great. Otherwise, it's not that big of a deal, but surprising still.

[wtgtybhertgeghgtwtg]

I accidently saved it as CRLF instead of LF. That should be fixed now.

[jfmengels]

Awesome, the diff is much easier to read now 😅

LGTM, thanks for your work on this :)

I'll give some time to @benmosher and @ljharb to review, and I'll merge this in a few days if they dontt have the time to look at it.

[wtgtybhertgeghgtwtg]

Thank you for helping me with this Pull Request.

[coveralls]

Coverage remained the same at 94.86% when pulling 1388a8d on wtgtybhertgeghgtwtg:master into bfdc2bb on benmosher:master.

[benmosher]

thanks @wtgtybhertgeghgtwtg!

[wtgtybhertgeghgtwtg]

Thank you for merging.