Add 'always-and-inside-groups' value to order's newlines-between option to allow newlines inside import groups

[giodamelio]

New option to allow newlines inside import groups. See #627.

[coveralls]

Coverage increased (+0.003%) to 94.899% when pulling bfd6222 on giodamelio:order-extra-newlines into d9605a0 on benmosher:master.

[coveralls]

Coverage increased (+0.003%) to 94.899% when pulling 42a780a on giodamelio:order-extra-newlines into d9605a0 on benmosher:master.

[coveralls]

Coverage increased (+0.003%) to 94.899% when pulling eabec08 on giodamelio:order-extra-newlines into d9605a0 on benmosher:master.

[giodamelio]

@jfmengels Just wanted to ping you and check on the status of this. I would love to get it merged if everything is in order.

[giodamelio]

I just updated this to the current master, @benmosher, could you take a look at this?

[coveralls]

Coverage increased (+0.003%) to 94.863% when pulling 5c1a3d1 on giodamelio:order-extra-newlines into bfdc2bb on benmosher:master.

[benmosher]

@giodamelio: need @jfmengels to review, order is his baby 😄

[jfmengels]

Hey @giodamelio!
First of all, sorry for not replying earlier... Totally dropped the ball there.
Second of all, thanks a lot, this looks really good :)

The only thing I would like to see changed, is the new option name. In my mind, newlines-between: "always-with-newlines" means the same thing as newlines-between: "always". Maybe newlines-between: "always-and-inside-groups" would be more explicit? What do you think?

(apart for this, this LGTM, and I'll fine with merging this)

Oh, you'll probably need to rebase, because the changelog has moved since you made the PR, and the section is now located inside a previous release description. If you don't know how to rebase, nevermind, I can fix this when merging, no problem.

[giodamelio]

"always-and-inside-groups" sounds good to me. Fix incoming.

[coveralls]

Coverage increased (+0.003%) to 94.912% when pulling 9507de9 on giodamelio:order-extra-newlines into ffc0205 on benmosher:master.

[giodamelio]

Should be all good to go.

[jfmengels]

Thanks a lot @giodamelio! 🎉

[coveralls]

Coverage increased (+0.003%) to 94.912% when pulling 9639f2e on giodamelio:order-extra-newlines into ffc0205 on benmosher:master.

[coveralls]

Coverage decreased (-1.3%) to 93.612% when pulling 9639f2e on giodamelio:order-extra-newlines into ffc0205 on benmosher:master.

[coveralls]

Coverage decreased (-1.3%) to 93.612% when pulling 9639f2e on giodamelio:order-extra-newlines into ffc0205 on benmosher:master.