[Fix] no-duplicates: type import fixer generates valid TypeScript

[GoodForOneFare]

Fixes #2114, #2130

Note that #2114 suggests the correct fix looks like:

import type {default as dnajs, AccountQuery} from '@netflix-internal/dnajs';

but this PR will generate:

import type dnajs from '@netflix-internal/dnajs';
import type {AccountQuery} from '@netflix-internal/dnajs';

This avoids conflicts with no-named-default mentioned in #2130.

[ljharb]

@GoodForOneFare are you no longer interested in landing this?

[nwalters512]

@ljharb would you have otherwise accepted this PR? I'd be happy to open a new PR and see it through, we've been bitten by this before.

[ljharb]

@nwalters512 please do not open a new PR - i'd prefer @GoodForOneFare to restore the branch and reopen this one, and i can take your branch and pull it into this PR.

I haven't had a chance to review this one, but any fixer that's safe is one I'm always anxious to add.

[nwalters512]

Sure - how long would you like to wait for @GoodForOneFare to reopen? If they've abandoned it entirely, I would still very much like to get this fix landed.

[GoodForOneFare]

Hi folks! I only had a short window in which I could contribute, so @nwalters512 can pick this up without stepping on my toes 😸

fwiw, even with this fix, enabling this + consistent-type-imports was too noisy for our largest repo 😞 If I was picking this back up, I'd get both rules to play nice by only mandating import type when there are no non-type imports for a dependency.

[ljharb]

@GoodForOneFare any chance you could restore the branch and reopen the PR? That way @nwalters512 can post a link to a branch and I can pull in the commits, without needing an extra PR.

[GoodForOneFare]

Done 👍 All yours, @nwalters512!

[ljharb]

@nwalters512 please comment with a link to a rebased/updated branch, and i'll pull it in :-)

[nwalters512]

@ljharb here you go! https://github.com/nwalters512/eslint-plugin-import/tree/no-duplicates-types