[New] order: Add warnOnUnassignedImports option to enable warnings for out of order unassigned imports#1990
Merged
Conversation
…s for out of order unassigned imports Fixes import-js#1639
Author
|
@ljharb would having a configurable whitelist of extensions that are safe to autofix as unassigned imports be acceptable? I know that side effects are generally not safe to re-order, but specifically for styles, there are use cases, where either ordering them can be known to be safe for a specific application. |
|
Specifically, css files are often safe to reorder (not always, but in many applications). Plus opting-in makes it a much safer operation. |
Member
|
@hayes let's explore that in a future issue. |
ljharb
force-pushed
the
mh--unassigned-imports
branch
from
d93eb29 to
dedd912
Compare
ljharb
changed the title
order: Add warnOnUnassignedImports option to enable warnings for out of order unassigned imports
ljharb
force-pushed
the
mh--unassigned-imports
branch
from
dedd912 to
a943fd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1639
This seems like a pretty simple solution, but does have one weird side effect: The behavior of the newline option changes slightly, in that it can now remove newlines between groups correctly when there are unassigned imports. This is only the case when the new option is enabled. Updating this to make that behavior consistent (always allow new-line changes around unassigned imports) would be safe, and easy to implement, but is a breaking change, so leaving it as is seems better.
cc @Alphy11 @ljharb