Enhancement alphabetize case insensitive#1586
Merged
ljharb merged 1 commit intoDec 30, 2019
Merged
Conversation
…phabetize` - imp: mutateRanksToAlphabetizeV2 added to handle case insensitive sorting - tests: add two test cases for alphabetize.caseInsensitive: true - docs: added documentation for new options: alphabetize.caseInsensitive - imp: merged mutateRanksToAlphabetizeV2 to original - changelog: updated with caseInsensitive addition
4 similar comments
ljharb
reviewed
Dec 30, 2019
| import aTypes from 'prop-types'; | ||
| import { compose, apply } from 'xcompose'; | ||
| import * as classnames from 'classnames'; | ||
| import blist from 'BList'; |
Member
There was a problem hiding this comment.
perhaps a relative path would be better here, since npm package names can't be capitalized (for many years now)
ljharb
force-pushed
the
enhancement-alphabetize-case-insensitive
branch
from
ad5e4dc to
c53a069
Compare
ljharb
approved these changes
Dec 30, 2019
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Actually let's just leave this as-is.
ljharb
force-pushed
the
enhancement-alphabetize-case-insensitive
branch
from
c53a069 to
c28fa7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1581