Deep namespaces#157
Merged
Merged
Conversation
first steps toward #119: collecting deep namespaces, and failing tests
# Conflicts: # gulpfile.js # src/core/getExports.js # src/rules/export.js # src/rules/namespace.js # tests/src/rules/namespace.js
benmosher
force-pushed
the
deep-namespace
branch
from
b3ca8de to
a55c974
Compare
This was referenced Apr 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #119 by converting
namedexports from aSetto aMap.Namespace exports will now have the exported space as their
namedvalue.import * as ns from 'foo'; export { ns }add destructured namespaces to namespaces? (probably should wait, scope is hairy)I can't even remember what I meant by this.export * as ns from 'x'syntax