[Fix] no-unused-modules: fix usage of import/extensions settings#1560
Merged
ljharb merged 1 commit intoDec 10, 2019
Merged
Conversation
stekycz
force-pushed
the
bugfix/no-unused-modules-settings-extensions
branch
from
acc6bd4 to
f3189d1
Compare
1 similar comment
ljharb
requested changes
Dec 9, 2019
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Could we add some tests for JS files as well, perhaps with the .jsx extension?
stekycz
force-pushed
the
bugfix/no-unused-modules-settings-extensions
branch
from
f3189d1 to
13e5c42
Compare
ljharb
force-pushed
the
bugfix/no-unused-modules-settings-extensions
branch
from
13e5c42 to
fdaf825
Compare
ljharb
approved these changes
Dec 10, 2019
Member
|
Tests seem to be failing in eslint 2-5. |
stekycz
force-pushed
the
bugfix/no-unused-modules-settings-extensions
branch
from
fdaf825 to
4e8960d
Compare
Contributor
Author
|
Should be fixed. I have tested it for eslint 2-6 on Node 10 on OSX. |
kristenmills
added a commit
to Flexget/webui
that referenced
this pull request
Dec 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1555