Skip to content

fix: import/no-cycle triggering errors for Flow imports#1494

Merged
ljharb merged 1 commit into
import-js:masterfrom
maxmalov:fix-flow-type-cycles
Dec 5, 2019
Merged

fix: import/no-cycle triggering errors for Flow imports#1494
ljharb merged 1 commit into
import-js:masterfrom
maxmalov:fix-flow-type-cycles

Conversation

@maxmalov
Copy link
Copy Markdown
Contributor

@maxmalov maxmalov commented Oct 5, 2019 •
edited
Loading

The changes fix a complex circular dependency where Flow type imports are transient dependencies of the checked module. Basically such imports can be ignored too since they will be stripped anyway

Fixes #1343

@maxmalov maxmalov changed the title Fix import/no-cycle triggering errors for Flow imports fix: import/no-cycle triggering errors for Flow imports Oct 5, 2019
102
102 reviewed Oct 5, 2019
View reviewed changes
Comment thread tests/files/cycles/flow-types.js
@coveralls
Copy link
Copy Markdown

coveralls commented Oct 5, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 96.07% when pulling 21bf8c6 on maxmalov:fix-flow-type-cycles into 0cd5e43 on benmosher:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 5, 2019

Coverage Status

Coverage decreased (-2.8%) to 92.574% when pulling 67ff5b8 on maxmalov:fix-flow-type-cycles into 5e143b2 on benmosher:master.

3 similar comments
@coveralls
Copy link
Copy Markdown

coveralls commented Oct 5, 2019

Coverage Status

Coverage decreased (-2.8%) to 92.574% when pulling 67ff5b8 on maxmalov:fix-flow-type-cycles into 5e143b2 on benmosher:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 5, 2019

Coverage Status

Coverage decreased (-2.8%) to 92.574% when pulling 67ff5b8 on maxmalov:fix-flow-type-cycles into 5e143b2 on benmosher:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 5, 2019

Coverage Status

Coverage decreased (-2.8%) to 92.574% when pulling 67ff5b8 on maxmalov:fix-flow-type-cycles into 5e143b2 on benmosher:master.

@ljharb ljharb added the flow label Oct 8, 2019
@dominicfraser dominicfraser mentioned this pull request Nov 24, 2019
Closed
@dominicfraser
Copy link
Copy Markdown

dominicfraser commented Nov 24, 2019

@102 @maxmalov - could we have an update on the status of this PR? :)

@maxmalov
Copy link
Copy Markdown
Contributor Author

maxmalov commented Nov 30, 2019

@dominicfraser yeah, the fix supposed to handle both type import variants import type { Foo } and import { type Bar }

@ljharb ljharb merged commit 21bf8c6 into import-js:master Dec 5, 2019
@rfermann rfermann mentioned this pull request Dec 11, 2019
Closed
@maxmalov maxmalov deleted the fix-flow-type-cycles branch December 25, 2019 14:18
@danielbartsch danielbartsch mentioned this pull request Feb 18, 2020
Closed
@cherryblossom000 cherryblossom000 mentioned this pull request Jan 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@102 102 102 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flow

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

import/no-cycle should not trigger for Flow imports

5 participants

@maxmalov @coveralls @dominicfraser @102 @ljharb