Skip to content

[fix] no-unused-modules: make import { name as otherName } work#1342

Merged
ljharb merged 2 commits into
import-js:masterfrom
rfermann:1339
Apr 24, 2019
Merged

[fix] no-unused-modules: make import { name as otherName } work#1342
ljharb merged 2 commits into
import-js:masterfrom
rfermann:1339

Conversation

@rfermann
Copy link
Copy Markdown
Contributor

@rfermann rfermann commented Apr 23, 2019

Fixes #1339, part 2

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 23, 2019

Coverage Status

Coverage increased (+2.5%) to 97.932% when pulling fbe5c30 on rfermann:1339 into 174afbb on benmosher:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+2.5%) to 97.983% when pulling 1db357e on rfermann:1339 into 174afbb on benmosher:master.

Copy link
Copy Markdown
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but can we get a test case for it too?

@rfermann
Copy link
Copy Markdown
Contributor Author

Thanks, but can we get a test case for it too?

Of course. A new test case is included in fbe5c30

Copy link
Copy Markdown
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb merged commit c17dd73 into import-js:master Apr 24, 2019
@rfermann rfermann deleted the 1339 branch April 25, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] import/no-unused-modules does not work with import { name as otherName }

3 participants