Skip to content

no-commonjs: add tests that show corner cases#1308

Merged
ljharb merged 1 commit into
import-js:masterfrom
TakeScoop:root-require
Mar 27, 2019
Merged

no-commonjs: add tests that show corner cases#1308
ljharb merged 1 commit into
import-js:masterfrom
TakeScoop:root-require

Conversation

@andrewtamura
Copy link
Copy Markdown

@andrewtamura andrewtamura commented Mar 25, 2019

No description provided.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 25, 2019

Coverage Status

Coverage increased (+3.2%) to 97.336% when pulling be4f1c7 on TakeScoop:root-require into 206d676 on benmosher:master.

1 similar comment
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 25, 2019

Coverage Status

Coverage increased (+3.2%) to 97.336% when pulling be4f1c7 on TakeScoop:root-require into 206d676 on benmosher:master.

@ljharb ljharb changed the title Add rules that show corner cases for commonJS no-commonjs: add tests that show corner cases Mar 27, 2019
ljharb
ljharb approved these changes Mar 27, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb merged commit af976b9 into import-js:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewtamura @coveralls @ljharb