Skip to content

Add no-named-export + docs/tests #1157

Merged
benmosher merged 4 commits into
import-js:masterfrom
fsmaia:no-named-export
Sep 9, 2018
Merged

Add no-named-export + docs/tests #1157
benmosher merged 4 commits into
import-js:masterfrom
fsmaia:no-named-export

Conversation

@fsmaia
Copy link
Copy Markdown
Contributor

@fsmaia fsmaia commented Aug 9, 2018

Fixes #1156.

@fsmaia fsmaia changed the title No named export Add no-named-export + docs/tests Aug 9, 2018
@coveralls
Copy link
Copy Markdown

coveralls commented Aug 9, 2018

Coverage Status

Coverage decreased (-0.1%) to 97.151% when pulling c506c5c on fsmaia:no-named-export into 2d4f651 on benmosher:master.

Copy link
Copy Markdown
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/rules/no-named-export.js Outdated
return {}
}

const preferDefault = 'Prefer default export.'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message could be a bit stricter.

@fsmaia
Copy link
Copy Markdown
Contributor Author

fsmaia commented Aug 22, 2018

Any news?

@benmosher benmosher merged commit f04b7b6 into import-js:master Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants