Skip to content

fix(oauth-providers): github oauth#1372

Merged
yusukebe merged 6 commits into
honojs:mainfrom
mrdear:bugfix/github_auth
Aug 12, 2025
Merged

fix(oauth-providers): github oauth#1372
yusukebe merged 6 commits into
honojs:mainfrom
mrdear:bugfix/github_auth

Conversation

@mrdear
Copy link
Copy Markdown
Contributor

@mrdear mrdear commented Aug 9, 2025

hi, after github oauth, the framework attempted to obtain the email, but the contentType was missing. This request would report a 400 error. This PR supplemented this contentType

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 9, 2025

🦋 Changeset detected

Latest commit: 650feb5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/oauth-providers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrdear mrdear changed the title Bugfix/GitHub auth fix(oauth-providers): github oauth Aug 9, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.07%. Comparing base (86a4ca4) to head (650feb5).
⚠️ Report is 124 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1372       +/-   ##
===========================================
- Coverage   79.32%   20.07%   -59.26%     
===========================================
  Files          81      103       +22     
  Lines        2443     3372      +929     
  Branches      633      867      +234     
===========================================
- Hits         1938      677     -1261     
- Misses        419     2178     +1759     
- Partials       86      517      +431     
Flag Coverage Δ
ajv-validator ?
arktype-validator ?
auth-js ?
bun-compress ?
casbin ?
class-validator ?
clerk-auth ?
cloudflare-access ?
conform-validator ?
effect-validator ?
esbuild-transpiler ?
event-emitter ?
firebase-auth ?
graphql-server ?
hello ?
medley-router ?
node-ws ?
oauth-providers 20.07% <ø> (-7.65%) ⬇️
oidc-auth ?
otel ?
prometheus ?
react-renderer ?
sentry ?
standard-validator ?
swagger-editor ?
swagger-ui ?
trpc-server ?
tsyringe ?
typebox-validator ?
typia-validator ?
valibot-validator ?
zod-openapi ?
zod-validator ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread .changeset/gentle-bugs-peel.md Outdated
Copy link
Copy Markdown
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Copy Markdown
Member

@mrdear Thanks! I'll merge and release a new version.

@yusukebe yusukebe merged commit 1980a66 into honojs:main Aug 12, 2025
84 of 86 checks passed
@github-actions github-actions Bot mentioned this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants