Remove dead host-path helper re-exports from agent-volumes#3563
Conversation
There was a problem hiding this comment.
Pull request overview
Cleans up stale API surface in the services layer by removing backwards-compatibility re-exports of host-path-prefix helpers from agent-volumes, leaving src/services/host-path-prefix.ts as the canonical module for those utilities.
Changes:
- Removed
normalizeDockerHostPathPrefix,translateBindMountHostPath, andapplyHostPathPrefixToVolumesre-exports fromsrc/services/agent-volumes.ts. - Narrowed
agent-volumes.tsto import onlyapplyHostPathPrefixToVolumes, which it uses internally.
Show a summary per file
| File | Description |
|---|---|
| src/services/agent-volumes.ts | Removes dead re-exports and narrows imports to keep host-path-prefix helpers owned by host-path-prefix.ts. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (2 files)
Coverage comparison generated by |
|
✅ Smoke Test Results
Status: PASS
|
🔥 Smoke Test: Copilot BYOK (Offline) Mode
Overall: PASS (core BYOK path verified) Running in BYOK offline mode ( PR author:
|
|
Merged PRs ✅ docs(spec): add port information to /reflect endpoint sections; fix(dind-probe): address review feedback from #3554 Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Chroot Smoke Test Results
Result: ❌ NOT ALL TESTS PASSED — Python and Node.js versions differ between host and chroot environment.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
Smoke Test Results — FAIL
Overall: FAIL
|
Smoke Test Results (Gemini) - GitHub MCP: ❌ (not found) - Connectivity: ❌ (Exit 35) - File Writing: ✅ - Bash: ✅ - Overall: FAILWarning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
🔬 Smoke Test Results
Overall: PASS PR: "Remove dead host-path helper re-exports from agent-volumes" by
|
src/services/agent-volumes.tsstill re-exported three host-path helper symbols that no longer have any callers. All known imports already come from the canonicalsrc/services/host-path-prefix.tsmodule, so the extra exports were stale API surface.API surface cleanup
normalizeDockerHostPathPrefixtranslateBindMountHostPathapplyHostPathPrefixToVolumesImport narrowing
agent-volumes.tsimporting only the helper it actually uses internally:applyHostPathPrefixToVolumesResult
agent-volumes.tsno longer advertises an obsolete import path for host-path-prefix helperssrc/services/host-path-prefix.ts