Skip to content

Remove dead host-path helper re-exports from agent-volumes#3563

Merged
lpcox merged 2 commits into
mainfrom
copilot/remove-backwards-compatibility-exports
May 22, 2026
Merged

Remove dead host-path helper re-exports from agent-volumes#3563
lpcox merged 2 commits into
mainfrom
copilot/remove-backwards-compatibility-exports

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 21, 2026

src/services/agent-volumes.ts still re-exported three host-path helper symbols that no longer have any callers. All known imports already come from the canonical src/services/host-path-prefix.ts module, so the extra exports were stale API surface.

  • API surface cleanup

    • Removed the backwards-compatibility re-export block for:
      • normalizeDockerHostPathPrefix
      • translateBindMountHostPath
      • applyHostPathPrefixToVolumes
  • Import narrowing

    • Kept agent-volumes.ts importing only the helper it actually uses internally: applyHostPathPrefixToVolumes
  • Result

    • agent-volumes.ts no longer advertises an obsolete import path for host-path-prefix helpers
    • The canonical ownership of these helpers remains src/services/host-path-prefix.ts
// before
import {
  normalizeDockerHostPathPrefix,
  translateBindMountHostPath,
  applyHostPathPrefixToVolumes,
} from './host-path-prefix';

export {
  normalizeDockerHostPathPrefix,
  translateBindMountHostPath,
  applyHostPathPrefixToVolumes,
};

// after
import { applyHostPathPrefixToVolumes } from './host-path-prefix';

Copilot AI changed the title [WIP] Remove unused re-exports in agent-volumes.ts Remove dead host-path helper re-exports from agent-volumes May 21, 2026
Copilot finished work on behalf of lpcox May 21, 2026 23:55
Copilot AI requested a review from lpcox May 21, 2026 23:55
@lpcox lpcox marked this pull request as ready for review May 22, 2026 00:08
Copilot AI review requested due to automatic review settings May 22, 2026 00:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Cleans up stale API surface in the services layer by removing backwards-compatibility re-exports of host-path-prefix helpers from agent-volumes, leaving src/services/host-path-prefix.ts as the canonical module for those utilities.

Changes:

  • Removed normalizeDockerHostPathPrefix, translateBindMountHostPath, and applyHostPathPrefixToVolumes re-exports from src/services/agent-volumes.ts.
  • Narrowed agent-volumes.ts to import only applyHostPathPrefixToVolumes, which it uses internally.
Show a summary per file
File Description
src/services/agent-volumes.ts Removes dead re-exports and narrows imports to keep host-path-prefix helpers owned by host-path-prefix.ts.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@github-actions
Copy link
Copy Markdown
Contributor

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 95.98% 96.05% 📈 +0.07%
Statements 95.81% 95.87% 📈 +0.06%
Functions 97.37% 98.02% 📈 +0.65%
Branches 89.42% 89.46% 📈 +0.04%
📁 Per-file Coverage Changes (2 files)
File Lines (Before → After) Statements (Before → After)
src/services/agent-volumes.ts 91.9% → 91.7% (-0.19%) 92.1% → 91.9% (-0.17%)
src/config-writer.ts 83.0% → 85.6% (+2.54%) 83.0% → 85.6% (+2.54%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results

  • ✅ GitHub API: 2 PR entries confirmed
  • ✅ GitHub check: playwright_check PASS
  • ✅ File verify: smoke-test artifact exists

Status: PASS

💥 [THE END] — Illustrated by Smoke Claude

@github-actions
Copy link
Copy Markdown
Contributor

🔥 Smoke Test: Copilot BYOK (Offline) Mode

Test Result
GitHub MCP connectivity ✅ PR listed via MCP
GitHub.com HTTP ⚠️ Pre-step vars not expanded
File write/read ⚠️ Pre-step vars not expanded
BYOK inference (this response)

Overall: PASS (core BYOK path verified)

Running in BYOK offline mode (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com.

PR author: @Copilot — assignees: @lpcox, @Copilot

🔑 BYOK report filed by Smoke Copilot BYOK

@github-actions
Copy link
Copy Markdown
Contributor

Merged PRs ✅ docs(spec): add port information to /reflect endpoint sections; fix(dind-probe): address review feedback from #3554
Safeinputs GH ❌ safeinputs-gh unavailable
Playwright ✅ GitHub title verified
Tavily ❌ no callable Tavily tools advertised
File + bash ✅ file written/read
Discussion ✅ oracle comment posted to #3562
Build ✅ npm ci && npm run build
Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

@github-actions
Copy link
Copy Markdown
Contributor

Chroot Smoke Test Results

Runtime Host Version Chroot Version Match?
Python Python 3.12.13 Python 3.12.3 ❌ NO
Node.js v24.15.0 v20.20.2 ❌ NO
Go go1.22.12 go1.22.12 ✅ YES

Result: ❌ NOT ALL TESTS PASSED — Python and Node.js versions differ between host and chroot environment.

Tested by Smoke Chroot

@github-actions
Copy link
Copy Markdown
Contributor

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color 1/1 passed ✅ PASS
Go env 1/1 passed ✅ PASS
Go uuid 1/1 passed ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx passed ✅ PASS
Node.js execa passed ✅ PASS
Node.js p-limit passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #3563 · ● 5.5M ·

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results — FAIL

Check Result
Redis PING ❌ Connection timed out
PostgreSQL pg_isready ❌ No response
PostgreSQL SELECT 1 ❌ No response

host.docker.internal resolves to 172.17.0.1 but ports 6379 and 5432 are unreachable. Service containers do not appear to be running or accessible from this environment.

Overall: FAIL

🔌 Service connectivity validated by Smoke Services

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results (Gemini) - GitHub MCP: ❌ (not found) - Connectivity: ❌ (Exit 35) - File Writing: ✅ - Bash: ✅ - Overall: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

@github-actions
Copy link
Copy Markdown
Contributor

🔬 Smoke Test Results

Test Result
GitHub MCP connectivity ✅ PR listed: "docs(spec): add port information to /reflect endpoint sections"
GitHub.com connectivity ✅ Reachable (MCP calls succeeded)
File write/read /tmp/gh-aw/agent/smoke-test-copilot-26260026732.txt verified

Overall: PASS

PR: "Remove dead host-path helper re-exports from agent-volumes" by @Copilot. Assignees: @lpcox, @Copilot.

📰 BREAKING: Report filed by Smoke Copilot

@lpcox lpcox merged commit c52e9fb into main May 22, 2026
66 of 71 checks passed
@lpcox lpcox deleted the copilot/remove-backwards-compatibility-exports branch May 22, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Export Audit] Dead backwards-compatibility re-exports in src/services/agent-volumes.ts (re-open: still present)

3 participants