Add first-class ARC/DinD compatibility mode for AWF by Copilot · Pull Request #2839 · github/gh-aw-firewall

Copilot · 2026-05-10T14:04:23Z

Inspect the failing PR comment, recent workflow runs/logs, and the touched test files
Reproduce the failure locally with existing lint/build/test commands and targeted tests
Make the smallest fix for the failing test and validate the affected area
Scan changed files for secrets, run final validation, and reply to the PR comment

github-actions · 2026-05-10T15:24:07Z

Documentation Preview

Documentation build failed for this PR. View logs.

Built from commit 3845610

github-actions · 2026-05-10T15:24:43Z

⚠️ Coverage Regression Detected

This PR decreases test coverage. Please add tests to maintain coverage levels.

Overall Coverage

Metric	Base	PR	Delta
Lines	87.37%	87.40%	📈 +0.03%
Statements	87.34%	87.39%	📈 +0.05%
Functions	82.70%	82.46%	📉 -0.24%
Branches	79.43%	79.52%	📈 +0.09%

📁 Per-file Coverage Changes (6 files)

File	Lines (Before → After)	Statements (Before → After)
`src/services/api-proxy-service.ts`	98.5% → 98.5% (+0.04%)	98.5% → 98.5% (+0.06%)
`src/services/agent-service.ts`	97.5% → 97.6% (+0.11%)	97.6% → 97.8% (+0.16%)
`src/services/agent-volumes.ts`	91.6% → 91.7% (+0.16%)	91.8% → 92.0% (+0.22%)
`src/cli.ts`	28.3% → 28.6% (+0.30%)	28.3% → 28.6% (+0.30%)
`src/services/cli-proxy-service.ts`	94.7% → 95.2% (+0.50%)	94.7% → 95.5% (+0.72%)
`src/container-lifecycle.ts`	87.1% → 88.2% (+1.14%)	87.5% → 88.6% (+1.11%)

✨ New Files (1 files)

src/arc-dind.ts: 100.0% lines

Coverage comparison generated by scripts/ci/compare-coverage.ts

Copilot

Pull request overview

Adds a first-class ARC/DinD compatibility mode to AWF so it can run on split runner/Docker-daemon filesystems by rewriting AWF-managed bind-mount source paths under a staging prefix (/tmp/gh-aw/arc-root) and providing CLI/config/schema/docs support plus detection warnings.

Changes:

Introduces --arc-dind / container.arcDind and wires it through config types, config-file mapping, CLI option parsing, and JSON schemas.
Adds ARC/DinD bind-source translation (translateArcDindBindSource) and applies it to AWF-managed bind mounts across agent volumes and sidecars (Squid/API proxy/CLI proxy/iptables-init).
Documents ARC/DinD staging expectations and adds unit tests covering translation and compose output rewrites.

Show a summary per file

File	Description
src/types/config.ts	Adds `WrapperConfig.arcDind` with detailed behavior docs.
src/services/squid-service.ts	Rewrites Squid bind-mount sources when `arcDind` is enabled.
src/services/cli-proxy-service.ts	Rewrites CLI proxy log + CA cert bind-mount sources when `arcDind` is enabled.
src/services/api-proxy-service.ts	Rewrites API proxy log bind-mount sources when `arcDind` is enabled.
src/services/agent-volumes.ts	Applies translation to AWF-managed agent/chroot-related bind sources.
src/services/agent-volumes.test.ts	Adds integration-style assertions that compose volumes are rewritten under the staging prefix.
src/services/agent-service.ts	Updates iptables-init service to translate its init-signal bind source.
src/schema.test.ts	Updates schema parity test fixture to include `arcDind`.
src/config-file.ts	Adds `container.arcDind` and maps it into CLI option space.
src/config-file.test.ts	Adds validation + mapping coverage for `container.arcDind`.
src/compose-generator.ts	Passes `config` into `buildIptablesInitService` so it can apply translation.
src/cli.ts	Adds `--arc-dind` flag and warns when `DOCKER_HOST` suggests ARC/DinD; plumbs `arcDind` into runtime config.
src/awf-config-schema.json	Extends schema with `container.arcDind`.
src/arc-dind.ts	New module: detection helper + bind-source translation logic and constants.
src/arc-dind.test.ts	Unit tests for detection + translation.
scripts/generate-schema.mjs	Ensures schema generation includes `container.arcDind`.
docs/environment.md	Documents ARC/DinD behavior, reference config, and staging contract.
docs/awf-config.schema.json	Updates published docs schema with `container.arcDind`.
docs/awf-config-spec.md	Documents `container.arcDind` ↔ `--arc-dind` mapping.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

src/arc-dind.ts:74

translateArcDindBindSource() isn’t idempotent: if a caller passes a path that’s already under ARC_DIND_BIND_PREFIX, it will be re-prefixed (e.g. /tmp/gh-aw/arc-root/... becomes /tmp/gh-aw/arc-root/tmp/gh-aw/arc-root/...). This can happen if users choose a workDir (or other paths) already inside the staging prefix. Consider short-circuiting when sourcePath === ARC_DIND_BIND_PREFIX or sourcePath starts with ${ARC_DIND_BIND_PREFIX}/.

export function translateArcDindBindSource(sourcePath: string): string {
  if (/^[A-Za-z]:[\\/]/.test(sourcePath) || sourcePath.startsWith('\\\\')) {
    return sourcePath;
  }

  if (!path.posix.isAbsolute(sourcePath)) {
    return sourcePath;
  }

  if (sourcePath === '/') {
    return ARC_DIND_BIND_PREFIX;
  }

  if (ARC_DIND_PASSTHROUGH_PATHS.has(sourcePath)) {
    return sourcePath;
  }

  if (ARC_DIND_PASSTHROUGH_PREFIXES.some(prefix => sourcePath === prefix || sourcePath.startsWith(`${prefix}/`))) {
    return sourcePath;
  }

  return path.posix.join(ARC_DIND_BIND_PREFIX, sourcePath.slice(1));
}

Files reviewed: 19/19 changed files
Comments generated: 3

+  if (dockerHost.startsWith('unix://')) {
+    if (DEFAULT_DOCKER_HOST_SOCKETS.has(dockerHost)) {
+      return { detected: false };
+    }
+
+    return {
+      detected: true,
+      dockerHost,
+      reason: 'non-default-unix-socket',
+    };
+  }
+
+  return {
+    detected: true,
+    dockerHost,
+    reason: 'tcp',
+  };


  const copilotHomeDir = path.join(effectiveHome, '.copilot');
  if (fs.existsSync(copilotHomeDir)) {
    try {
      fs.accessSync(copilotHomeDir, fs.constants.R_OK | fs.constants.W_OK);
-      agentVolumes.push(`${copilotHomeDir}:/host${effectiveHome}/.copilot:rw`);
+      agentVolumes.push(`${sourcePath(copilotHomeDir)}:/host${effectiveHome}/.copilot:rw`);
    } catch (error) {


    volumes: [
      // Log directory for HTTP server logs
-      `${cliProxyLogsPath}:/var/log/cli-proxy:rw`,
+      `${sourcePath(cliProxyLogsPath)}:/var/log/cli-proxy:rw`,
      // Mount host CA cert for TLS verification
-      ...(config.difcProxyCaCert ? [`${config.difcProxyCaCert}:/tmp/proxy-tls/ca.crt:ro`] : []),
+      ...(config.difcProxyCaCert ? [`${sourcePath(config.difcProxyCaCert)}:/tmp/proxy-tls/ca.crt:ro`] : []),
    ],


lpcox · 2026-05-10T15:29:12Z

@copilot address the review feedback

Copilot · 2026-05-10T15:33:55Z

@copilot address the review feedback

Addressed in 59b4819.

This follow-up narrows ARC/DinD auto-detection to explicit tcp:// hosts, makes the optional ~/.copilot bind check use the translated ARC/DinD source path, and adds focused regression tests for the translated .copilot gating and cli-proxy volume rewrites.

/dev and /sys are kernel virtual filesystems provided by the Docker daemon itself, not runner files staged under a prefix path. Prefixing them would look for non-existent directories under the runner root. This aligns with the approach in PR #2839 which uses explicit passthrough prefixes for these paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…2843) * Initial plan * feat: add docker host path prefix remapping * fix: address docker host prefix review feedback * fix: exclude /dev and /sys from docker host path prefix translation /dev and /sys are kernel virtual filesystems provided by the Docker daemon itself, not runner files staged under a prefix path. Prefixing them would look for non-existent directories under the runner root. This aligns with the approach in PR #2839 which uses explicit passthrough prefixes for these paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: add hidepid=2 to procfs mount and /proc to passthrough list Defense-in-depth against credential leakage via /proc/*/environ: 1. entrypoint.sh: Mount procfs with hidepid=2 so awfuser cannot read PID 1's /proc/1/environ, which may briefly hold auth tokens before unset_sensitive_tokens() clears them. This also blocks indirect access via /dev/fd → /proc/self/fd symlink traversal. 2. agent-volumes.ts: Add /proc to the kernel virtual filesystem passthrough list alongside /dev and /sys. While /proc is not bind-mounted (it uses mount -t proc), this is a defensive guard against accidental exposure through path prefix translation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Landon Cox <landon.cox@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

The --docker-host-path-prefix flag from PR #2843 fully supersedes the --arc-dind feature. This merge brings in main (which includes #2841 and #2843) and removes the now-redundant arc-dind module and inline sourcePath() wrappers. Changes: - Delete src/arc-dind.ts and src/arc-dind.test.ts (orphaned) - Remove --arc-dind CLI option, config, schema, and docs - Remove sourcePath() wrappers from all service builders - Keep --docker-host-path-prefix with centralized translation in buildAgentVolumes() and kernel VFS passthrough (/dev, /sys, /proc) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

lpcox · 2026-05-10T19:25:26Z

@copilot fix this failing test #2839 (comment)

Copilot · 2026-05-10T19:29:42Z

@copilot fix this failing test #2839 (comment)

Addressed in 8be1476. The build-test workflow now uses plain git clone https://github.com/... for the public test repositories instead of gh repo clone, so it no longer depends on GH_TOKEN for those clones.

github-actions · 2026-05-10T19:41:49Z

🧪 Smoke Test: Copilot BYOK (Offline) Mode

Test	Result
GitHub MCP connectivity	⚠️ 401 (MCP not authenticated in sandbox)
GitHub.com HTTP	✅ (pre-step verified)
File write/read (`smoke-test-copilot-byok-25637703141.txt`)	✅ Content confirmed
BYOK inference (agent → api-proxy → api.githubcopilot.com)	✅ Responding normally

Running in BYOK offline mode (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com.

Overall: PASS

🔑 BYOK report filed by Smoke Copilot BYOK

github-actions · 2026-05-10T19:41:50Z

Smoke Test Results

❌ GitHub MCP Testing (gh pr list: auth issue)
✅ Playwright Testing (GitHub page loaded)
✅ File Writing Testing (file created)
✅ Bash Tool Testing (file verified)

Status: PARTIAL (3/4 passed; gh auth config issue)

💥 [THE END] — Illustrated by Smoke Claude

github-actions · 2026-05-10T19:42:35Z

Smoke Test Results

🔌 GitHub MCP: ❌ (401 Bad credentials — token not propagated)
🌐 GitHub.com HTTP: ⚠️ (pre-step template vars not expanded)
📁 File write/read: ✅ (smoke-test-copilot-25637703145.txt confirmed)

Overall: FAIL — MCP connectivity could not be verified.

Pre-step file: "Smoke test passed for Copilot at Sun May 10 19:40:00 UTC 2026"

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-05-10T19:42:55Z

Smoke Codex: FAIL
PR: Fix chroot bind mounts for ARC/DinD split runner-daemon filesystems
PR: Honor Unix DOCKER_HOST sockets for DinD mounts on ARC runners
GitHub PR review ✅ / SafeInputs ❌ / Playwright ✅ / Tavily ❌
File+Bash ✅ / Discussion ❌ / Build ✅
Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

github-actions · 2026-05-10T19:43:46Z

Smoke Test Results — FAIL

Check	Result
Redis PING	❌ No response (timeout)
PostgreSQL pg_isready	❌ No response
PostgreSQL SELECT 1	❌ Not attempted (pg_isready failed)

host.docker.internal is unreachable on both ports 6379 and 5432. Service containers may not be running in this environment.

🔌 Service connectivity validated by Smoke Services

github-actions · 2026-05-10T19:44:41Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	passed	✅ PASS
Go	env	✅	passed	✅ PASS
Go	uuid	✅	passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	passed	✅ PASS
Node.js	execa	✅	passed	✅ PASS
Node.js	p-limit	✅	passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Note (Java): The default ~/.m2/repository was owned by root and not writable. Maven was run with -Dmaven.repo.local=/tmp/gh-aw/agent/m2-repo as a workaround; all tests passed successfully.

Generated by Build Test Suite for issue #2839 · ● 665K · ◷

Initial plan

ce95fb9

Copilot AI assigned Copilot and lpcox May 10, 2026

Copilot started work on behalf of lpcox May 10, 2026 14:04 View session

Copilot AI linked an issue May 10, 2026 that may be closed by this pull request

[awf] compiler: GAW missing first-class ARC runner validation and compatibility for AWF workflows #2834

Closed

feat: add ARC DinD compatibility mode

afd7b5f

Copilot AI changed the title ~~[WIP] Fix GAW missing first-class ARC runner validation for AWF workflows~~ Add first-class ARC/DinD compatibility mode for AWF May 10, 2026

Copilot AI requested a review from lpcox May 10, 2026 14:23

Copilot finished work on behalf of lpcox May 10, 2026 14:23

lpcox marked this pull request as ready for review May 10, 2026 15:23

lpcox requested a review from Mossaka as a code owner May 10, 2026 15:23

Copilot AI review requested due to automatic review settings May 10, 2026 15:23

Copilot started reviewing on behalf of lpcox May 10, 2026 15:24 View session

This comment has been minimized.

Sign in to view

github-actions Bot added the build-test label May 10, 2026

This comment has been minimized.

Sign in to view

Copilot AI reviewed May 10, 2026

View reviewed changes

Copilot started work on behalf of lpcox May 10, 2026 15:29 View session

fix: address ARC DinD review feedback

59b4819

Copilot AI added 2 commits May 10, 2026 15:35

test: refine ARC DinD regression setup

9e24270

test: simplify ARC DinD mount fixture

dae0f3a

This comment has been minimized.

Sign in to view

Copilot started work on behalf of lpcox May 10, 2026 19:25 View session

fix: use git clone in build-test workflow

8be1476

Copilot finished work on behalf of lpcox May 10, 2026 19:30

Copilot AI requested a review from lpcox May 10, 2026 19:30

github-actions Bot added the smoke-copilot-byok label May 10, 2026

lpcox merged commit 55b6df7 into main May 10, 2026
53 of 56 checks passed

lpcox deleted the copilot/awf-fix-gaw-arc-runner-validation branch May 10, 2026 20:30

This was referenced May 11, 2026

[docs] Add --anthropic-auto-cache and --anthropic-cache-tail-ttl documentation #2881

Merged

Harden gh-aw extension install in CI/CD gaps assessment workflow #2904

Merged

Copilot AI mentioned this pull request May 12, 2026

Auto-detect ARC/DinD and emit AWF --docker-host-path-prefix in generated workflows github/gh-aw#31614

Merged

5 tasks

Conversation

Copilot AI commented May 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Documentation Preview

Uh oh!

github-actions Bot commented May 10, 2026

⚠️ Coverage Regression Detected

Overall Coverage

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

lpcox commented May 10, 2026

Uh oh!

Copilot AI commented May 10, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

lpcox commented May 10, 2026

Uh oh!

Copilot AI commented May 10, 2026

Uh oh!

github-actions Bot commented May 10, 2026

🧪 Smoke Test: Copilot BYOK (Offline) Mode

Uh oh!

github-actions Bot commented May 10, 2026

Smoke Test Results

Uh oh!

github-actions Bot commented May 10, 2026

Smoke Test Results

Uh oh!

github-actions Bot commented May 10, 2026

Uh oh!

github-actions Bot commented May 10, 2026

Smoke Test Results — FAIL

Uh oh!

github-actions Bot commented May 10, 2026

🏗️ Build Test Suite Results

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 10, 2026 •

edited

Loading

github-actions Bot commented May 10, 2026 •

edited

Loading