Skip to content

(setup cost estimation logs): replace banners with tracing spans#520

Merged
zeroXbrock merged 3 commits into
mainfrom
feat/replace-banners-with-tracing-spans
Apr 20, 2026
Merged

(setup cost estimation logs): replace banners with tracing spans#520
zeroXbrock merged 3 commits into
mainfrom
feat/replace-banners-with-tracing-spans

Conversation

@zeroXbrock
Copy link
Copy Markdown
Member

@zeroXbrock zeroXbrock commented Apr 20, 2026

Motivation

The banners and un-marked logs from the sim running were kinda confusing and clogged up the logs. Using tracing spans will allow us to filter them out if/when we want.

Solution

  • remove banners
  • add tracing span to TestScenario::estimate_setup_cost; logs are now marked with the prefix simulate_setup_cost

snapshot of the new logs:

new-tracing-spans

PR Checklist

  • Added Tests
  • Added Documentation
  • Ran cargo +nightly clippy --workspace --lib --examples --tests --benches --all-features --locked --fix
  • Ran cargo fmt --all
  • Note breaking changes in PR description, if applicable
  • update changelogs
    • Update CHANGELOG.md in each affected crate
    • add a high-level description in the root changelog

@zeroXbrock zeroXbrock merged commit bca9f37 into main Apr 20, 2026
6 checks passed
@zeroXbrock zeroXbrock deleted the feat/replace-banners-with-tracing-spans branch April 20, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant