Support for missing parameters#3
Merged
Merged
Conversation
| json += '${$asString(key)}:' | ||
| ` | ||
| if (obj.${key} !== undefined) { | ||
| json += '${$asString(key)}:'` |
Member
There was a problem hiding this comment.
please close the '`' in the new line
Member
|
I agree on using I'm 100% open to have a configuration switch to use Anyway, this is a major difference from |
Member
Author
|
Totally agree with you, in the next commit I'll add the README and code changes. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using example.js as schema, this is the generated code:
If a parameter is required, there will be the
elsebranch.As you can see I'm not using
obj.hasOwnProperty(prop)for testing the existence of the key (is commented inside the code), because I've noticed a big difference of performances.When using
obj.key !== undefinedI get around 5 million ops/sec, instead if I useobj.hasOwnProperty(prop)I get ~2 million ops/sec.The problem is that
obj.key !== undefinedis not strict asobj.hasOwnProperty(prop).Opinions?