Skip to content

[Infra] Add verbose logging for work directory in runAgent#93

Merged
JanKrivanek merged 1 commit into
dotnet:mainfrom
ViktorHofer:main
Feb 23, 2026
Merged

[Infra] Add verbose logging for work directory in runAgent#93
JanKrivanek merged 1 commit into
dotnet:mainfrom
ViktorHofer:main

Conversation

@ViktorHofer
Copy link
Copy Markdown
Member

Log the work directory and skill type when verbose mode is enabled.

Log the work directory and skill type when verbose mode is enabled.
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds additional verbose-mode diagnostics to the skill validator runner to help understand where the agent session is executing and whether it’s using a skill or running baseline.

Changes:

  • Emit a verbose log line showing the temporary work directory path.
  • Include whether the run is “skilled” vs “baseline” in that verbose log.
Comments suppressed due to low confidence (2)

eng/skill-validator/src/runner.ts:131

  • write is initialized here and again inside the verbose event handler (and the event handler currently allocates a new function on every event). Consider hoisting a single const write = … near the top of runAgent (or when verbose is true) and reusing it for both the work-dir message and per-event logging to avoid duplication and per-event allocations.
  if (verbose) {
    const write = options.log ?? ((msg: string) => process.stderr.write(`${msg}\n`));
    write(`      📂 Work dir: ${workDir} (${skill ? 'skilled' : 'baseline'})`);
  }

eng/skill-validator/src/runner.ts:130

  • This template literal uses single-quoted string literals ('skilled'/'baseline') in a file that otherwise consistently uses double quotes for string literals. Consider switching these to double quotes for consistency within the TypeScript codebase.
    write(`      📂 Work dir: ${workDir} (${skill ? 'skilled' : 'baseline'})`);

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JanKrivanek JanKrivanek merged commit b982d3d into dotnet:main Feb 23, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants