[Infra] Add verbose logging for work directory in runAgent#93
Merged
Conversation
Log the work directory and skill type when verbose mode is enabled.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional verbose-mode diagnostics to the skill validator runner to help understand where the agent session is executing and whether it’s using a skill or running baseline.
Changes:
- Emit a verbose log line showing the temporary work directory path.
- Include whether the run is “skilled” vs “baseline” in that verbose log.
Comments suppressed due to low confidence (2)
eng/skill-validator/src/runner.ts:131
writeis initialized here and again inside the verbose event handler (and the event handler currently allocates a new function on every event). Consider hoisting a singleconst write = …near the top ofrunAgent(or whenverboseis true) and reusing it for both the work-dir message and per-event logging to avoid duplication and per-event allocations.
if (verbose) {
const write = options.log ?? ((msg: string) => process.stderr.write(`${msg}\n`));
write(` 📂 Work dir: ${workDir} (${skill ? 'skilled' : 'baseline'})`);
}
eng/skill-validator/src/runner.ts:130
- This template literal uses single-quoted string literals (
'skilled'/'baseline') in a file that otherwise consistently uses double quotes for string literals. Consider switching these to double quotes for consistency within the TypeScript codebase.
write(` 📂 Work dir: ${workDir} (${skill ? 'skilled' : 'baseline'})`);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JanKrivanek
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log the work directory and skill type when verbose mode is enabled.