Skip to content

Fix pr-number input type: use string instead of number#208

Merged
JanKrivanek merged 1 commit into
mainfrom
fix/pr-number-type
Mar 4, 2026
Merged

Fix pr-number input type: use string instead of number#208
JanKrivanek merged 1 commit into
mainfrom
fix/pr-number-type

Conversation

@ViktorHofer
Copy link
Copy Markdown
Member

Reusable workflow inputs typed as
umber\ reject string values from job outputs (which are always strings). This caused the
un-evaluation\ reusable workflow call to fail immediately in the fork PR evaluation workflow.

Changes:

  • \�valuation-run.yml: Change \pr-number\ input from \ ype: number\ to \ ype: string, update default and skip condition
  • \�valuation.yml: Update fallback from \

Reusable workflow inputs typed as 'number' reject string values
from job outputs. Change pr-number to type: string and update
the skip condition and default accordingly.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@ViktorHofer ViktorHofer requested a review from JanKrivanek as a code owner March 4, 2026 18:53
Copilot AI review requested due to automatic review settings March 4, 2026 18:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a GitHub Actions reusable workflow input type mismatch that caused the fork PR evaluation workflow to fail when passing a PR number via job outputs (strings) into an input declared as a number.

Changes:

  • Change pr-number input type in evaluation-run.yml from number to string, with '' meaning “skip commenting”.
  • Update the PR-number fallback in evaluation.yml from 0 to '' and align the comment-posting skip condition accordingly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/evaluation.yml Updates the pr-number value passed into the reusable workflow to use empty-string as the “no PR” sentinel.
.github/workflows/evaluation-run.yml Retypes pr-number to string and updates the conditional that decides whether to comment on the PR.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/evaluation.yml
ViktorHofer

This comment was marked as duplicate.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2026

Skill Validation Results

Skill Scenario Baseline With Skill Δ Skills Loaded Overfit Verdict
dotnet-trace-collect High CPU in Kubernetes on Linux (.NET 8) 4.0/5 4.5/5 ⏰ timeout +0.5 ✅ dotnet-trace-collect; tools: skill, report_intent, view, glob, bash ✅ 0.17
dotnet-trace-collect .NET Framework on Windows without admin privileges 2.0/5 5.0/5 +3.0 ✅ dotnet-trace-collect; tools: skill ✅ 0.17
dotnet-trace-collect .NET 10 on Linux with root access and native call stacks 1.5/5 4.0/5 +2.5 ✅ dotnet-trace-collect; tools: skill, bash ✅ 0.17
dotnet-trace-collect Memory leak on Linux (.NET 8) 2.0/5 3.0/5 +1.0 ✅ dotnet-trace-collect; tools: skill, bash ✅ 0.17
dotnet-trace-collect Slow requests on Windows with PerfView 3.5/5 5.0/5 +1.5 ✅ dotnet-trace-collect; tools: skill, report_intent, view ✅ 0.17
dotnet-trace-collect Excessive GC on Linux (.NET 8) 4.5/5 5.0/5 +0.5 ✅ dotnet-trace-collect; tools: skill ✅ 0.17
dotnet-trace-collect Hang or deadlock diagnosis on Linux 3.0/5 3.5/5 +0.5 ✅ dotnet-trace-collect; tools: skill, report_intent, view ✅ 0.17
dotnet-trace-collect Windows container high CPU with PerfView 1.5/5 5.0/5 +3.5 ✅ dotnet-trace-collect; tools: skill, report_intent, view, glob ✅ 0.17
dotnet-trace-collect Long-running intermittent issue with PerfView triggers 2.0/5 4.5/5 ⏰ timeout +2.5 ✅ dotnet-trace-collect; tools: skill, report_intent, view ✅ 0.17
dotnet-trace-collect Linux pre-.NET 10 needing native call stacks 2.0/5 5.0/5 +3.0 ✅ dotnet-trace-collect; tools: skill ✅ 0.17
dotnet-trace-collect Windows modern .NET with admin high CPU 2.0/5 5.0/5 +3.0 ✅ dotnet-trace-collect; tools: skill, report_intent, view ✅ 0.17
dotnet-trace-collect Memory leak on .NET Framework Windows 3.5/5 5.0/5 +1.5 ✅ dotnet-trace-collect; tools: skill, report_intent, view ✅ 0.17
dotnet-trace-collect Kubernetes with console access prefers console tools 5.0/5 5.0/5 0.0 ✅ dotnet-trace-collect; tools: skill, report_intent, view, glob, bash ✅ 0.17
dotnet-trace-collect Container installation without .NET SDK 3.5/5 4.5/5 +1.0 ✅ dotnet-trace-collect; tools: skill, bash ✅ 0.17
microbenchmarking Investigate runtime upgrade performance impact 3.0/5 ⏰ timeout 4.0/5 +1.0 ✅ microbenchmarking; tools: skill, glob, stop_bash ✅ 0.17
csharp-scripts Test a C# language feature with a script 3.0/5 3.5/5 +0.5 ✅ csharp-scripts; tools: skill, edit, create, view 🟡 0.31
clr-activation-debugging Diagnose unexpected FOD dialog from native build tool 1.0/5 5.0/5 +4.0 ✅ clr-activation-debugging; tools: skill ✅ 0.06
clr-activation-debugging Diagnose FOD suppressed but activation still failing 1.0/5 5.0/5 +4.0 ✅ clr-activation-debugging; tools: skill ✅ 0.06
clr-activation-debugging Explain why same binary behaves differently under different launch methods 1.0/5 5.0/5 +4.0 ✅ clr-activation-debugging; tools: skill ✅ 0.06
clr-activation-debugging Analyze healthy managed EXE activation 1.0/5 5.0/5 +4.0 ✅ clr-activation-debugging; tools: skill ✅ 0.06
clr-activation-debugging Identify multiple activation sequences in a single log 1.0/5 5.0/5 +4.0 ✅ clr-activation-debugging; tools: skill ✅ 0.06
clr-activation-debugging Explain useLegacyV2RuntimeActivationPolicy in activation log 2.0/5 4.0/5 +2.0 ✅ clr-activation-debugging; tools: skill ✅ 0.06
clr-activation-debugging Decline non-CLR-activation issue 1.0/5 5.0/5 +4.0 ℹ️ not activated (expected) ✅ 0.06
thread-abort-migration Worker thread with abort-based cancellation 5.0/5 5.0/5 0.0 ✅ thread-abort-migration; tools: skill, report_intent ✅ 0.14
thread-abort-migration Timeout enforcement via Thread.Abort 4.5/5 4.5/5 0.0 ✅ thread-abort-migration; tools: skill ✅ 0.14
thread-abort-migration Blocking WaitHandle with Thread.Interrupt 4.0/5 4.5/5 +0.5 ✅ thread-abort-migration; tools: skill ✅ 0.14
thread-abort-migration ASP.NET Response.End and Response.Redirect with Thread.Abort 4.0/5 5.0/5 +1.0 ✅ thread-abort-migration; tools: skill ✅ 0.14
thread-abort-migration Thread.Join and Thread.Sleep only — should not migrate 2.5/5 5.0/5 +2.5 ✅ thread-abort-migration; tools: skill ✅ 0.14
migrate-nullable-references Enable NRT in a small library with mixed nullability 5.0/5 5.0/5 0.0 ✅ migrate-nullable-references; tools: skill, glob ✅ 0.05
migrate-nullable-references File-by-file migration: only modify the targeted file 5.0/5 5.0/5 0.0 ⚠️ NOT ACTIVATED ✅ 0.05
migrate-nullable-references Enable NRT in ASP.NET Core Web API with EF Core 3.0/5 3.0/5 0.0 ✅ migrate-nullable-references; tools: skill ✅ 0.05
analyzing-dotnet-performance Detects compiled regex startup budget and regex chain allocations 1.0/5 4.5/5 ⏰ timeout +3.5 ✅ analyzing-dotnet-performance; tools: skill ✅ 0.16
analyzing-dotnet-performance Detects CurrentCulture comparer and compiled regex budget in inflection rules 1.0/5 5.0/5 ⏰ timeout +4.0 ✅ analyzing-dotnet-performance; tools: skill ✅ 0.16
analyzing-dotnet-performance Finds per-call Dictionary allocation not hoisted to static 1.0/5 5.0/5 +4.0 ✅ analyzing-dotnet-performance; tools: skill ✅ 0.16
analyzing-dotnet-performance Catches compound allocations in recursive number converter with ToLower 1.0/5 4.5/5 +3.5 ✅ analyzing-dotnet-performance; tools: skill ✅ 0.16
analyzing-dotnet-performance Finds StringComparison.Ordinal missing and FrozenDictionary opportunities 1.0/5 4.0/5 ⏰ timeout +3.0 ✅ analyzing-dotnet-performance; tools: skill, grep ✅ 0.16
analyzing-dotnet-performance Detects Aggregate+Replace chain and struct missing IEquatable 1.0/5 4.5/5 ⏰ timeout +3.5 ✅ analyzing-dotnet-performance; tools: skill ✅ 0.16
analyzing-dotnet-performance Finds branched Replace chain in format string manipulation 1.0/5 3.5/5 +2.5 ✅ analyzing-dotnet-performance; tools: skill ✅ 0.16
analyzing-dotnet-performance Catches LINQ on hot-path string processing and All(char.IsUpper) 1.0/5 5.0/5 +4.0 ✅ analyzing-dotnet-performance; tools: skill ✅ 0.16
analyzing-dotnet-performance Detects LINQ pipeline in TimeSpan formatting and collection processing 1.0/5 4.5/5 +3.5 ✅ analyzing-dotnet-performance; tools: skill ✅ 0.16
analyzing-dotnet-performance Flags Span inconsistencies and compound method chains in truncation library 1.0/5 4.5/5 +3.5 ✅ analyzing-dotnet-performance; tools: skill, read_bash ✅ 0.16
analyzing-dotnet-performance Identifies unsealed leaf classes and locale hierarchy patterns 1.0/5 5.0/5 +4.0 ✅ analyzing-dotnet-performance; tools: skill ✅ 0.16
dotnet-aot-compat Make Azure.ResourceManager AOT-compatible 2.5/5 2.5/5 ⏰ timeout 0.0 ✅ dotnet-aot-compat; tools: skill, bash, create ✅ 0.14
optimizing-ef-core-queries Optimize bulk operations with EF Core 7+ ExecuteUpdate and ExecuteDelete 5.0/5 5.0/5 0.0 ✅ optimizing-ef-core-queries; tools: skill 🟡 0.45
android-tombstone-symbolication Symbolicate .NET frames in an Android tombstone 4.0/5 4.5/5 +0.5 ✅ android-tombstone-symbolication; tools: skill, glob ✅ 0.15
android-tombstone-symbolication Recognize tombstone with no .NET frames 5.0/5 5.0/5 0.0 ✅ android-tombstone-symbolication; tools: skill, bash ✅ 0.15
android-tombstone-symbolication Symbolicate CoreCLR frames in an Android tombstone 3.0/5 ⏰ timeout 3.5/5 +0.5 ✅ android-tombstone-symbolication; tools: skill, glob, stop_bash ✅ 0.15
android-tombstone-symbolication Recognize NativeAOT tombstone with app binary and libSystem.Native.so 3.0/5 4.0/5 +1.0 ✅ android-tombstone-symbolication; tools: skill ✅ 0.15
android-tombstone-symbolication Symbolicate multi-thread tombstone 4.5/5 4.5/5 0.0 ✅ android-tombstone-symbolication; tools: skill, glob, stop_bash ✅ 0.15
android-tombstone-symbolication Handle .NET frames with no BuildId metadata 4.5/5 5.0/5 +0.5 ✅ android-tombstone-symbolication; tools: skill, bash ✅ 0.15
android-tombstone-symbolication Symbolicate tombstone with multiple .NET libraries and different BuildIds 4.0/5 4.0/5 0.0 ✅ android-tombstone-symbolication; tools: skill, stop_bash, glob ✅ 0.15
android-tombstone-symbolication Reject iOS crash log as wrong format 5.0/5 5.0/5 0.0 ℹ️ not activated (expected) ✅ 0.15
dotnet-pinvoke Generate LibraryImport declaration from C header (.NET 8+) 3.0/5 5.0/5 +2.0 ✅ dotnet-pinvoke; tools: skill ✅ 0.07
dotnet-pinvoke Generate LibraryImport declaration from C header (.NET Framework) 5.0/5 5.0/5 0.0 ✅ dotnet-pinvoke; tools: skill ✅ 0.07
dump-collect Configure automatic crash dumps for CoreCLR app on Linux 4.5/5 5.0/5 +0.5 ✅ dump-collect; tools: skill, report_intent, view, glob, bash ✅ 0.10
dump-collect Set up NativeAOT crash dumps with createdump in Kubernetes 2.0/5 5.0/5 +3.0 ✅ dump-collect; tools: skill ✅ 0.10
dump-collect Recover crash dump from macOS NativeAOT without createdump 4.0/5 3.5/5 -0.5 ⚠️ NOT ACTIVATED ✅ 0.10
dump-collect Configure CoreCLR dump collection in Alpine Docker as non-root 3.0/5 4.0/5 +1.0 ✅ dump-collect; tools: skill, report_intent, view, glob, bash ✅ 0.10
dump-collect Advisory: macOS NativeAOT crash dump recovery steps 3.5/5 3.5/5 0.0 ✅ dump-collect; tools: skill, bash ✅ 0.10
dump-collect Advisory: CoreCLR Alpine Docker non-root configuration 4.0/5 5.0/5 +1.0 ✅ dump-collect; tools: skill, view ✅ 0.10
dump-collect Advisory: NativeAOT Kubernetes dump collection setup 2.0/5 3.5/5 +1.5 ✅ dump-collect; tools: skill, bash ✅ 0.10
dump-collect Detect runtime and configure crash dumps for unknown .NET app on Linux 4.0/5 4.0/5 0.0 ✅ dump-collect; tools: skill ✅ 0.10
dump-collect Decline dump analysis request 3.0/5 3.0/5 0.0 ✅ tools: glob ✅ 0.10
build-parallelism Analyze build parallelism bottlenecks 1.0/5 ⏰ timeout 1.0/5 ⏰ timeout 0.0 ✅ build-parallelism; binlog-generation; tools: skill, edit, task ✅ 0.14
including-generated-files Diagnose generated file inclusion failure 3.0/5 5.0/5 +2.0 ✅ including-generated-files; tools: skill ✅ 0.18
msbuild-antipatterns Review MSBuild files for anti-patterns and style issues 5.0/5 5.0/5 0.0 ✅ msbuild-antipatterns; tools: skill, glob ✅ 0.06
build-perf-baseline Establish build performance baseline and recommend optimizations 3.0/5 3.5/5 ⏰ timeout +0.5 ✅ binlog-generation; build-perf-baseline; build-parallelism; build-perf-diagnostics; msbuild-antipatterns; tools: skill 🟡 0.24
msbuild-modernization Modernize legacy project to SDK-style 4.5/5 5.0/5 +0.5 ✅ msbuild-modernization; tools: skill, edit, bash ✅ 0.03
directory-build-organization Organize build infrastructure for a multi-project repo 3.5/5 5.0/5 +1.5 ✅ msbuild-antipatterns; directory-build-organization; tools: skill ✅ 0.14
check-bin-obj-clash Diagnose bin/obj output path clashes 4.0/5 4.0/5 ⏰ timeout 0.0 ✅ check-bin-obj-clash; binlog-generation; tools: skill, glob, edit 🟡 0.20
incremental-build Analyze incremental build issues 3.0/5 4.0/5 +1.0 ✅ incremental-build; tools: skill ✅ 0.14
eval-performance Analyze MSBuild evaluation performance issues 4.0/5 5.0/5 +1.0 ✅ eval-performance; tools: skill ✅ 0.13
build-perf-diagnostics Analyze analyzer performance impact on builds 5.0/5 4.0/5 ⏰ timeout -1.0 ✅ binlog-generation; binlog-failure-analysis; build-perf-diagnostics; tools: skill, edit 🟡 0.24
binlog-generation Build project with /bl flag 1.0/5 5.0/5 +4.0 ✅ binlog-generation; tools: skill ✅ 0.00
binlog-generation Build with /bl in PowerShell 3.0/5 5.0/5 +2.0 ✅ binlog-generation; tools: skill ✅ 0.00
binlog-generation Build multiple configurations with unique binlogs 2.0/5 5.0/5 +3.0 ✅ binlog-generation; tools: skill ✅ 0.00
binlog-failure-analysis Diagnose build failures from binlog only (no source files) 3.0/5 ⏰ timeout 5.0/5 +2.0 ✅ binlog-failure-analysis; tools: skill ✅ 0.04

timeout — run hit the scenario timeout limit; scoring may be impacted by aborting model execution before it could produce its full output

Model: claude-opus-4.6 | Judge: claude-opus-4.6

Full results

@JanKrivanek JanKrivanek merged commit 9bcc11c into main Mar 4, 2026
11 checks passed
@JanKrivanek JanKrivanek deleted the fix/pr-number-type branch March 4, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants