Skip to content

Remove skills that violate guidelines#162

Merged
JanKrivanek merged 1 commit into
mainfrom
dev/jaredpar/fix
Mar 2, 2026
Merged

Remove skills that violate guidelines#162
JanKrivanek merged 1 commit into
mainfrom
dev/jaredpar/fix

Conversation

@jaredpar
Copy link
Copy Markdown
Member

@jaredpar jaredpar commented Mar 2, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 2, 2026 19:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes several dotnet-msbuild skills and deletes the precompiled knowledge bundles that are imported by dotnet-msbuild agentic workflows.

Changes:

  • Deleted three plugins/dotnet-msbuild skills (build-perf-diagnostics, build-parallelism, binlog-failure-analysis).
  • Deleted two auto-generated compiled knowledge lock files under agentic-workflows/dotnet-msbuild/shared/compiled/.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
plugins/dotnet-msbuild/skills/build-perf-diagnostics/SKILL.md Removes the build performance diagnostics skill content.
plugins/dotnet-msbuild/skills/build-parallelism/SKILL.md Removes the build parallelism tuning skill content.
plugins/dotnet-msbuild/skills/binlog-failure-analysis/SKILL.md Removes the binlog-based build failure analysis skill content.
agentic-workflows/dotnet-msbuild/shared/compiled/performance.lock.md Removes the compiled performance knowledge bundle used by workflows.
agentic-workflows/dotnet-msbuild/shared/compiled/build-errors.lock.md Removes the compiled build-errors knowledge bundle used by workflows.
Comments suppressed due to low confidence (5)

plugins/dotnet-msbuild/skills/binlog-failure-analysis/SKILL.md:1

  • This skill is still referenced by agentic-workflows/dotnet-msbuild/build.ps1 (in the build-errors knowledge group) and by plugins/dotnet-msbuild/agents/msbuild.agent.md. If the skill is removed to meet guidelines, update the compilation group and agent docs to avoid pointing users/workflows to a non-existent skill.
    agentic-workflows/dotnet-msbuild/shared/compiled/performance.lock.md:1
  • This file is still imported by the agentic workflow agentic-workflows/dotnet-msbuild/build-perf-audit.md (imports: - shared/compiled/performance.lock.md). Deleting it will break workflow resolution unless the workflow import is updated or the lock file continues to be generated and committed at this path.
    agentic-workflows/dotnet-msbuild/shared/compiled/build-errors.lock.md:1
  • This file is still imported by agentic-workflows/dotnet-msbuild/build-failure-analysis.md (imports: - shared/compiled/build-errors.lock.md). Removing it will cause that workflow to fail to load unless the import is removed/changed or the lock file is regenerated and kept in the repo.
    plugins/dotnet-msbuild/skills/build-perf-diagnostics/SKILL.md:1
  • This skill name is referenced by the knowledge compilation script (agentic-workflows/dotnet-msbuild/build.ps1 includes it in the performance knowledge group) and by agents docs (e.g., plugins/dotnet-msbuild/agents/build-perf.agent.md, plugins/dotnet-msbuild/agents/msbuild.agent.md). After deleting the skill, those references will be dangling; update/remove them or replace with an alternative skill to keep agent guidance and compiled knowledge consistent.
    plugins/dotnet-msbuild/skills/build-parallelism/SKILL.md:1
  • This skill is still included in the performance knowledge group in agentic-workflows/dotnet-msbuild/build.ps1 and referenced by agent documentation (e.g., plugins/dotnet-msbuild/agents/build-perf.agent.md, plugins/dotnet-msbuild/agents/msbuild.agent.md). Deleting it without updating those references will leave broken pointers and reduce the usefulness of compiled knowledge.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yolo review :)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 2, 2026

Skill Validation Results

Skill Scenario Baseline With Skill Δ Skills Loaded Overfit Verdict
microbenchmarking Investigate runtime upgrade performance impact 2.5/5 ⏰ timeout 4.0/5 +1.5 ✅ microbenchmarking; tools: skill, read_bash, glob ✅ 0.12
csharp-scripts Test a C# language feature with a script 2.5/5 4.0/5 +1.5 ✅ csharp-scripts; tools: skill, create, edit, view 🟡 0.31
clr-activation-debugging Diagnose unexpected FOD dialog from native build tool 1.0/5 5.0/5 +4.0 ✅ clr-activation-debugging; tools: skill ✅ 0.09
clr-activation-debugging Diagnose FOD suppressed but activation still failing 1.0/5 5.0/5 +4.0 ✅ clr-activation-debugging; tools: skill ✅ 0.09
clr-activation-debugging Explain why same binary behaves differently under different launch methods 1.0/5 5.0/5 +4.0 ✅ clr-activation-debugging; tools: skill ✅ 0.09
clr-activation-debugging Analyze healthy managed EXE activation 1.0/5 5.0/5 +4.0 ✅ clr-activation-debugging; tools: skill ✅ 0.09
clr-activation-debugging Identify multiple activation sequences in a single log 1.0/5 5.0/5 +4.0 ✅ clr-activation-debugging; tools: skill ✅ 0.09
clr-activation-debugging Explain useLegacyV2RuntimeActivationPolicy in activation log 2.0/5 4.0/5 +2.0 ✅ clr-activation-debugging; tools: skill ✅ 0.09
clr-activation-debugging Decline non-CLR-activation issue 1.0/5 5.0/5 +4.0 ✅ clr-activation-debugging; tools: skill ✅ 0.09
thread-abort-migration Worker thread with abort-based cancellation 5.0/5 5.0/5 0.0 ✅ thread-abort-migration; tools: skill, report_intent ✅ 0.10
thread-abort-migration Timeout enforcement via Thread.Abort 5.0/5 4.5/5 -0.5 ✅ thread-abort-migration; tools: report_intent, skill ✅ 0.10
thread-abort-migration Blocking WaitHandle with Thread.Interrupt 3.5/5 5.0/5 +1.5 ✅ thread-abort-migration; tools: skill ✅ 0.10
thread-abort-migration ASP.NET Response.End and Response.Redirect with Thread.Abort 4.0/5 5.0/5 +1.0 ✅ thread-abort-migration; tools: skill, report_intent ✅ 0.10
thread-abort-migration Thread.Join and Thread.Sleep only — should not migrate 3.0/5 5.0/5 +2.0 ✅ thread-abort-migration; tools: skill ✅ 0.10
migrate-nullable-references Enable NRT in a small library with mixed nullability 5.0/5 5.0/5 0.0 ✅ migrate-nullable-references; tools: skill ✅ 0.06
migrate-nullable-references File-by-file migration: only modify the targeted file 5.0/5 5.0/5 0.0 ⚠️ NOT ACTIVATED ✅ 0.06
migrate-nullable-references Enable NRT in ASP.NET Core Web API with EF Core 3.0/5 3.0/5 0.0 ✅ migrate-nullable-references; tools: skill ✅ 0.06
analyzing-dotnet-performance Detects compiled regex startup budget and regex chain allocations 1.0/5 5.0/5 +4.0 ✅ analyzing-dotnet-performance; tools: skill ✅ 0.18
analyzing-dotnet-performance Detects CurrentCulture comparer and compiled regex budget in inflection rules 1.0/5 5.0/5 +4.0 ✅ analyzing-dotnet-performance; tools: skill ✅ 0.18
analyzing-dotnet-performance Finds per-call Dictionary allocation not hoisted to static 1.0/5 5.0/5 +4.0 ✅ analyzing-dotnet-performance; tools: skill ✅ 0.18
analyzing-dotnet-performance Catches compound allocations in recursive number converter with ToLower 1.0/5 4.0/5 +3.0 ✅ analyzing-dotnet-performance; tools: skill ✅ 0.18
analyzing-dotnet-performance Finds StringComparison.Ordinal missing and FrozenDictionary opportunities 1.0/5 4.0/5 +3.0 ✅ analyzing-dotnet-performance; tools: skill ✅ 0.18
analyzing-dotnet-performance Detects Aggregate+Replace chain and struct missing IEquatable 1.0/5 4.0/5 ⏰ timeout +3.0 ✅ analyzing-dotnet-performance; tools: skill ✅ 0.18
analyzing-dotnet-performance Finds branched Replace chain in format string manipulation 1.0/5 3.5/5 +2.5 ✅ analyzing-dotnet-performance; tools: skill ✅ 0.18
analyzing-dotnet-performance Catches LINQ on hot-path string processing and All(char.IsUpper) 1.0/5 5.0/5 +4.0 ✅ analyzing-dotnet-performance; tools: skill ✅ 0.18
analyzing-dotnet-performance Detects LINQ pipeline in TimeSpan formatting and collection processing 1.0/5 4.0/5 +3.0 ✅ analyzing-dotnet-performance; tools: skill, task, glob ✅ 0.18
analyzing-dotnet-performance Flags Span inconsistencies and compound method chains in truncation library 1.0/5 5.0/5 +4.0 ✅ analyzing-dotnet-performance; tools: skill ✅ 0.18
analyzing-dotnet-performance Identifies unsealed leaf classes and locale hierarchy patterns 1.0/5 5.0/5 +4.0 ✅ analyzing-dotnet-performance; tools: skill ✅ 0.18
optimizing-ef-core-queries Optimize bulk operations with EF Core 7+ ExecuteUpdate and ExecuteDelete 4.5/5 4.5/5 0.0 ✅ optimizing-ef-core-queries; tools: skill 🟡 0.21
android-tombstone-symbolication Symbolicate .NET frames in an Android tombstone 4.0/5 5.0/5 +1.0 ✅ android-tombstone-symbolication; tools: skill, glob ✅ 0.09
android-tombstone-symbolication Recognize tombstone with no .NET frames 5.0/5 5.0/5 0.0 ✅ android-tombstone-symbolication; tools: skill, bash ✅ 0.09
android-tombstone-symbolication Symbolicate CoreCLR frames in an Android tombstone 2.5/5 ⏰ timeout 4.0/5 +1.5 ✅ android-tombstone-symbolication; tools: skill, glob, read_bash ✅ 0.09
android-tombstone-symbolication Recognize NativeAOT tombstone with app binary and libSystem.Native.so 3.0/5 4.5/5 +1.5 ✅ android-tombstone-symbolication; tools: skill, bash, glob ✅ 0.09
android-tombstone-symbolication Symbolicate multi-thread tombstone 4.0/5 5.0/5 +1.0 ✅ android-tombstone-symbolication; tools: skill, glob ✅ 0.09
android-tombstone-symbolication Handle .NET frames with no BuildId metadata 4.0/5 5.0/5 +1.0 ✅ android-tombstone-symbolication; tools: skill, glob, bash ✅ 0.09
android-tombstone-symbolication Symbolicate tombstone with multiple .NET libraries and different BuildIds 3.0/5 2.5/5 ⏰ timeout -0.5 ✅ android-tombstone-symbolication; tools: skill, glob, read_bash ✅ 0.09
android-tombstone-symbolication Reject iOS crash log as wrong format 5.0/5 5.0/5 0.0 ⚠️ NOT ACTIVATED ✅ 0.09
android-tombstone-symbolication Run automation script in parse-only mode 1.0/5 4.0/5 +3.0 ⚠️ NOT ACTIVATED ✅ 0.09
android-tombstone-symbolication Run automation script in parse-only mode on multi-thread tombstone 1.0/5 4.0/5 +3.0 ⚠️ NOT ACTIVATED ✅ 0.09
android-tombstone-symbolication Run automation script with -CrashingThreadOnly 1.5/5 5.0/5 +3.5 ⚠️ NOT ACTIVATED ✅ 0.09
dotnet-pinvoke Generate LibraryImport declaration from C header (.NET 8+) 3.5/5 5.0/5 +1.5 ✅ dotnet-pinvoke; tools: skill ✅ 0.05
dotnet-pinvoke Generate LibraryImport declaration from C header (.NET Framework) 5.0/5 5.0/5 0.0 ✅ dotnet-pinvoke; tools: skill ✅ 0.05
dump-collect Configure automatic crash dumps for CoreCLR app on Linux 4.5/5 5.0/5 +0.5 ✅ dump-collect; tools: skill, report_intent, view, glob, bash ✅ 0.09
dump-collect Set up NativeAOT crash dumps with createdump in Kubernetes 2.5/5 5.0/5 +2.5 ✅ dump-collect; tools: skill ✅ 0.09
dump-collect Recover crash dump from macOS NativeAOT without createdump 4.5/5 4.0/5 -0.5 ✅ dump-collect; tools: skill, report_intent, view, glob ✅ 0.09
dump-collect Configure CoreCLR dump collection in Alpine Docker as non-root 2.5/5 4.5/5 +2.0 ✅ dump-collect; tools: skill, glob ✅ 0.09
dump-collect Advisory: macOS NativeAOT crash dump recovery steps 3.5/5 4.0/5 +0.5 ✅ dump-collect; tools: skill ✅ 0.09
dump-collect Advisory: CoreCLR Alpine Docker non-root configuration 4.0/5 5.0/5 +1.0 ✅ dump-collect; tools: skill ✅ 0.09
dump-collect Advisory: NativeAOT Kubernetes dump collection setup 3.0/5 2.5/5 -0.5 ✅ dump-collect; tools: skill ✅ 0.09
dump-collect Detect runtime and configure crash dumps for unknown .NET app on Linux 4.0/5 4.0/5 0.0 ✅ dump-collect; tools: skill, glob ✅ 0.09
dump-collect Decline dump analysis request 3.5/5 4.0/5 +0.5 ℹ️ not activated (expected) ✅ 0.09
build-parallelism Analyze build parallelism bottlenecks 2.5/5 ⏰ timeout 4.0/5 +1.5 ✅ build-parallelism; binlog-generation; binlog-failure-analysis; tools: skill, task, glob, edit ✅ 0.14
including-generated-files Diagnose generated file inclusion failure 3.0/5 5.0/5 +2.0 ✅ including-generated-files; tools: skill 🟡 0.21
msbuild-antipatterns Review MSBuild files for anti-patterns and style issues 5.0/5 5.0/5 0.0 ✅ msbuild-antipatterns; tools: skill, glob ✅ 0.06
build-perf-baseline Establish build performance baseline and recommend optimizations 3.5/5 4.0/5 +0.5 ✅ build-perf-baseline; build-perf-diagnostics; tools: skill, edit 🟡 0.26
msbuild-modernization Modernize legacy project to SDK-style 5.0/5 5.0/5 0.0 ✅ msbuild-modernization; tools: skill ✅ 0.06
directory-build-organization Organize build infrastructure for a multi-project repo 3.5/5 4.5/5 +1.0 ✅ directory-build-organization; msbuild-antipatterns; tools: skill, glob 🟡 0.20
check-bin-obj-clash Diagnose bin/obj output path clashes 3.5/5 4.5/5 ⏰ timeout +1.0 ✅ check-bin-obj-clash; binlog-generation; tools: skill, edit ✅ 0.13
incremental-build Analyze incremental build issues 3.0/5 4.0/5 +1.0 ✅ incremental-build; tools: skill ✅ 0.14
eval-performance Analyze MSBuild evaluation performance issues 4.0/5 4.5/5 +0.5 ✅ eval-performance; tools: skill ✅ 0.11
build-perf-diagnostics Analyze analyzer performance impact on builds 5.0/5 4.0/5 ⏰ timeout -1.0 ✅ binlog-generation; binlog-failure-analysis; build-perf-diagnostics; tools: skill, edit 🟡 0.22
binlog-generation Build project with /bl flag 1.0/5 5.0/5 +4.0 ✅ binlog-generation; tools: skill, read_bash ✅ 0.00
binlog-generation Build with /bl in PowerShell 2.5/5 5.0/5 +2.5 ✅ binlog-generation; tools: skill ✅ 0.00
binlog-generation Build multiple configurations with unique binlogs 2.5/5 5.0/5 +2.5 ✅ binlog-generation; tools: skill ✅ 0.00
binlog-failure-analysis Diagnose build failures from binlog only (no source files) 4.5/5 5.0/5 +0.5 ✅ binlog-failure-analysis; tools: skill ✅ 0.03

timeout — run hit the scenario timeout limit; scoring may be impacted by aborting model execution before it could produce its full output

Model: claude-opus-4.6 | Judge: claude-opus-4.6

Full results

@JanKrivanek JanKrivanek merged commit 4793aa2 into main Mar 2, 2026
9 of 10 checks passed
@JanKrivanek JanKrivanek deleted the dev/jaredpar/fix branch March 2, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants