Refine parameter description in generate-benchmark-data.ps1 and add s…#110
Merged
Conversation
…afeDirName function to sanitize skill names in reporter.ts
JanKrivanek
approved these changes
Feb 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens filesystem safety in skill-validator by preventing skill names from being used for path traversal when creating per-skill report directories, and updates PowerShell help text for the dashboard benchmark generator.
Changes:
- Add
safeDirName()to validate skill names before using them as a directory segment inreporter.ts. - Use
safeDirName(verdict.skillName)when writing per-skill markdown and JSON outputs. - Simplify the
.PARAMETER ResultsFiledescription ingenerate-benchmark-data.ps1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| eng/skill-validator/src/reporter.ts | Adds directory-segment validation for skillName and applies it to per-skill output directories. |
| eng/dashboard/generate-benchmark-data.ps1 | Refines comment-based help for ResultsFile. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…idator
- Slugify skill names for directory use instead of hard-failing on
unexpected characters from SKILL.md frontmatter display names.
- Use path.basename() for robust single-segment check instead of
string.includes('..') which false-positives on names like 'foo..bar'.
- Throw on genuinely invalid names (empty, '.', '..', or all-special-chars).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Skill Validation Results
Model: claude-opus-4.6 | Judge: claude-opus-4.6 |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…afeDirName function to sanitize skill names in reporter.ts
Addressing valid follow-up feedback from Copilot in #108