fix: pin Python to 3.12 in vLLM and SGLang build stages#883
Merged
Conversation
![gemini-code-assist[bot]](https://ghub.bbstale.com/avatars/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the Dockerfile to Python 3.12 and updates CUDA dependencies to version 13.0. Review feedback identifies critical issues where the uv pip install commands lack explicit virtual environment paths and the hardcoding of the CUDA version ignores established build arguments.
Replace generic python3/python3-venv/python3-dev packages with explicit python3.12 variants to ensure a consistent runtime across distro updates. Simplify the vLLM install by letting uv resolve the Python version (--python 3.12) and using unsafe-best-match index strategy with the cu130 wheels index. Signed-off-by: Eric Curtin <eric.curtin@docker.com>
ericcurtin
force-pushed
the
pin-python312-vllm-sglang
branch
from
13b2df7 to
5f7cd48
Compare
ilopezluna
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
python3/python3-venv/python3-devapt packages with explicitpython3.12variants in both the vLLM and SGLang Dockerfile build stages to ensure a consistent Python runtime across distro updates.uvresolve the interpreter via--python 3.12instead of pointing at/usr/bin/python3, and use thecu130wheels index with--index-strategy unsafe-best-match.--python 3.12withuv.python3.12explicitly.