fix appearance of raycaster (fixes aframevr#4882)#4884
Conversation
mikemainguy
left a comment
There was a problem hiding this comment.
Can we get this into 1.4.2? This is more prominent in new release. I actually think only the second half is necessary (line 381). I tested just that change locally and it fixes the problem for me. I'm not sure about the changes on lines 104-106.
raycaster.mp4Attached example of problem @dmarcos can we merge? |
Just want to add that I'm pretty sure both changes are necessary to fully fix the issue. Just making the second the second change will make it look better in certain scenarios (i.e. when the origin is close to <0,0,0> or when the origin is displaced in the raycaster's direction), but it won't fix it in all cases. I'd also definitely like to see this get merged. I brought up this bug initially because the raycaster for the controller I was using would be noticeably inaccurate whenever it started intersecting with something close to it, which looks like the same thing you're experiencing. |
|
thanks! |
Description: Fixes issue #4882
Changes proposed: