Remove unnecessary sleep(1000) in test resetState#3869
Merged
Conversation
rom1504
force-pushed
the
remove-reset-sleep
branch
from
1cfda3d to
cbef2b2
Compare
Remove the 1s sleep between resetBlocksToSuperflat and clearInventory. /fill executes synchronously on the server, so the sleep is unnecessary. Saves ~45s across the full test suite (1s × 45 tests). Tested locally on 1.9.4: 45/45 passing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rom1504
force-pushed
the
remove-reset-sleep
branch
from
cbef2b2 to
dbc6404
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resetBlocksToSuperflat()andclearInventory()inresetState/fillexecutes synchronously on the server, so the sleep is not needed🤖 Generated with Claude Code