Update typescript and fix dts syntax#3366
Merged
Merged
Conversation
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/mineflayer@3.18.0, npm/node-canvas-webgl@0.2.7, npm/three@0.126.1 |
mallusrgreatv2
changed the title
extremeheat
approved these changes
Jun 1, 2024
Member
extremeheat
left a comment
extremeheat
left a comment
There was a problem hiding this comment.
LGTM, but we should have a way to test out the types to make sure they're valid at least
extremeheat
reviewed
Jun 1, 2024
| "standard": "^17.0.0", | ||
| "standard-markdown": "^7.1.0", | ||
| "typescript": "^5.0.3" | ||
| "typescript": "^5.4.5" |
Member
There was a problem hiding this comment.
since we are using the ^ (caret) operator, npm will automatically install the latest version of typescript@5.* , see https://docs.npmjs.com/cli/v6/using-npm/semver#caret-ranges-123-025-004
AreaDenial
added a commit
to AreaDenial/mineflayer
that referenced
this pull request
Jun 5, 2024
Fix typescript types syntax for setCommandBlock (PrismarineJS#3366)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates typescript version and makes changes in the definition file to fix syntax.