cuda : fix KQ mask offset integer overflow in flash attention MMA kernel#23610
Open
fairydreaming wants to merge 1 commit into
Open
cuda : fix KQ mask offset integer overflow in flash attention MMA kernel#23610fairydreaming wants to merge 1 commit into
fairydreaming wants to merge 1 commit into
Conversation
| #pragma unroll | ||
| for (int j1 = 0; j1 < ncols1; j1 += stride_j) { | ||
| const int j_sram = j1 + threadIdx.y*cols_per_warp + threadIdx.x / (warp_size/cols_per_warp); | ||
| const int j_vram = fastmodulo(j0 + j_sram, ne01); |
Contributor
There was a problem hiding this comment.
Suggested change
| const int64_t j_vram = fastmodulo(j0 + j_sram, ne01); |
I would say it's better to do the upcast on this line instead because an overflow of a 32 bit signed integer here would be upcast to a negative 64 bit integer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
When using long context and large ubatch size KQ mask becomes very large during prompt processing with the number of elements exceeding INT32_MAX (for example in GLM-5.1 max context size is 202752, so with 16k ubatch we have 3321888768 KQ mask elements). This results in negative
j_vram*stride_maskmask_h array offset in flash attention MMA kernel as confirmed by printfs:Casting
j_vramtoint64_tso that the calculated offset is alsoint64_tresolves this problem.Fixes #23574.
Requirements