cmake : error when LLAMA_BUILD_APP=ON and LLAMA_BUILD_TOOLS=OFF#23580
Open
Pento95 wants to merge 1 commit into
Open
cmake : error when LLAMA_BUILD_APP=ON and LLAMA_BUILD_TOOLS=OFF#23580Pento95 wants to merge 1 commit into
Pento95 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
LLAMA_BUILD_APP=ON silently fails to compile when LLAMA_BUILD_TOOLS=OFF because the app/ targets depend on impl targets defined in tools/ (e.g. llama-server-impl, llama-cli-impl). The error manifests as a missing build-info.h header, which is misleading and hard to diagnose.
This PR adds an explicit FATAL_ERROR when the incompatible combination is used, so the user gets a clear message instead of a cryptic compiler error.
Additional information
Tested with CMake 4.3.0 on Fedora 44 (Linux 7.0.9-205.fc44.x86_64).
With LLAMA_BUILD_APP=ON and LLAMA_BUILD_TOOLS=OFF, CMake now exits immediately with:
LLAMA_BUILD_APP requires LLAMA_BUILD_TOOLS to be enabled
Requirements
Alternative fix
Claude suggested a more user-friendly approach:
if (LLAMA_BUILD_APP AND NOT LLAMA_BUILD_TOOLS)
message(WARNING "LLAMA_BUILD_APP requires LLAMA_BUILD_TOOLS, enabling it automatically")
set(LLAMA_BUILD_TOOLS ON CACHE BOOL "" FORCE)
endif()