fix(vllm-metal): enable tool calling support in backend args#783
Merged
Conversation
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
--enable-auto-tool-choiceand--tool-call-parser hermesflags are now always enabled for the metal backend; consider making these options configurable or conditional so non-tool-calling use cases are not forced into this behavior. - If other vllm backends (non-metal) also need tool-calling support, it may be worth aligning the argument construction across backends to avoid inconsistent behavior between runtimes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `--enable-auto-tool-choice` and `--tool-call-parser hermes` flags are now always enabled for the metal backend; consider making these options configurable or conditional so non-tool-calling use cases are not forced into this behavior.
- If other vllm backends (non-metal) also need tool-calling support, it may be worth aligning the argument construction across backends to avoid inconsistent behavior between runtimes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables tool calling support for the vllm-metal backend by adding the necessary command-line arguments. While this fixes the reported issue, the current implementation hardcodes these arguments, which applies them to all models. My review includes a suggestion to make this feature configurable to ensure flexibility and prevent potential issues with models that do not support tool calling.
ilopezluna
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
after #771.