build: clarify GitHub Actions build secret inputs#25195
Merged
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
the
area/build
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The documentation changes are clear, technically accurate, and well-structured. The new content separates action input behavior from Dockerfile secret mount behavior, adds a useful reference table, and provides a practical example for secret-envs. The prose avoids hedge words, marketing language, and meta-commentary. Scope is proportionate to the existing document.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates the GitHub Actions build secrets documentation to explain how
docker/build-push-actionsecret inputs map to Buildx secret source semantics.The page now separates action input behavior from Dockerfile secret mount behavior, adds a table for
secrets,secret-envs, andsecret-files, and includes an example for usingsecret-envswith a Dockerfileenvmount.Users were conflating where a secret value comes from with how a Dockerfile consumes that secret during a
RUNinstruction, especially aroundsecret-envs.Related issues or tickets
Reviews