Make Company optional in the UI (frontend-only)#780
Merged
Conversation
Form labels Company 'optional', client validation no longer flags it as Required when blank, and the submit handler stubs '(not provided)' into the payload when the user leaves it empty so the worker's existing 'company required' contract stays untouched. Worker, schema, and DB are not changed. Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
backnotprop
force-pushed
the
fix/workspaces-company-optional
branch
from
509f954 to
66dca8f
Compare
backnotprop
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workspaces waitlist form now treats Company as optional. Frontend-only — no worker, schema, or DB changes.
Changes
apps/marketing/src/pages/workspaces/index.astroCompany→Company optionalif (!company) Requiredclient-side validation(not provided)into the payload before sending so the worker's existing "company required" contract stays untouchedBehavior
Acmefor@acme.com) — server still does this for non-empty stubs? Actually no: the stub is non-empty, so server skips inference and stores(not provided)(not provided)Trade-off: corporate emails that leave the field blank no longer get the auto-inferred company name (the stub passes the truthy check before inference runs). Most users will type a real value; a few will get
(not provided).Test plan
company = '(not provided)'Generated with Devin