test: Mark test_resource_management flaky on Windows#1919
Merged
Conversation
The prior timeout bump did not address the real failure mode: on Windows under xdist load, Chromium hits `net::ERR_NO_BUFFER_SPACE` when opening the socket — not a slow response. Match the existing project precedent for this exact failure (`@pytest.mark.flaky(reruns=3)`).
vdusek
added
t-tooling
vdusek
added
t-tooling
github-actions
Bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1919 +/- ##
=======================================
Coverage 92.91% 92.92%
=======================================
Files 167 167
Lines 11714 11714
=======================================
+ Hits 10884 10885 +1
+ Misses 830 829 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mantisus
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tests/unit/browsers/test_browser_pool.py::test_resource_managementfailed on master CI (Windows, Python 3.10) withplaywright._impl._errors.Error: Page.goto: net::ERR_NO_BUFFER_SPACE— see run 26453810483.The previous fix (#1916) bumped the
gototimeout to 60s, but the failure is not a slow response — it's a hard kernel-level socket buffer exhaustion on Windows when many xdist workers simultaneously launch Chromium and open sockets. A larger timeout cannot help.Mark the test with
@pytest.mark.flaky(reruns=3)to match the existing project precedent for this exact failure mode (seetest_stagehand_browser_controller.pyandtest_adaptive_playwright_crawler.py).