MINOR: Move TransactionStateManager leaf case classes to Java records in transaction-coordinator#22334
Open
sjhajharia wants to merge 2 commits into
Open
MINOR: Move TransactionStateManager leaf case classes to Java records in transaction-coordinator#22334sjhajharia wants to merge 2 commits into
sjhajharia wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As part of the larger effort to move
TransactionStateManagerfrom coreto the
transaction-coordinatormodule and convert it to Java, this PRextracts the 7 leaf data classes that lived inside
TransactionStateManager.scalaand reimplements them as Java records inorg.apache.kafka.coordinator.transaction. They have no coupling to themanager itself and can move independently.
Changes
New Java records in transaction-coordinator:
log messages)
numTransactionalEntries=Y)
the canonical 11-arg constructor with the same
*_DEFAULTconstants theold Scala defaults referenced, preserving the TransactionConfig() test
ergonomics
Removed from TransactionStateManager.scala: all 7 case class
definitions; unused ServerConfigs import.
Call-site updates:
imports, prepended new to record construction.
TransactionCoordinatorConcurrencyTest,
TransactionMarkerRequestCompletionHandlerTest,
TransactionMarkerChannelManagerTest : same treatment.