[fix](be) Fix unused constant/function build errors in md5.cpp #63608
Open
zwy991114 wants to merge 1 commit into
Open
[fix](be) Fix unused constant/function build errors in md5.cpp #63608zwy991114 wants to merge 1 commit into
zwy991114 wants to merge 1 commit into
Conversation
Author
|
/review |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #63484
Problem Summary:
The constants
MD5_A0/B0/C0/D0and the helper functionsmd5_num_blocks/md5_pad_final_blocksinbe/src/util/md5.cppare only referenced inside the#ifdef __AVX2__multi-buffer code path. On builds without AVX2 support, the compiler reports-Wunused-const-variableand-Wunused-function, which are promoted to errors via-Werrorand break the build.Move these AVX2-only declarations under the same
#ifdef __AVX2__guard that protects their sole consumer.MD5_DUMMY_INPUTandmd5_to_hexremain outside the guard since both code paths use them.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)