fix(@angular/ssr): support server-side rendering configuration options#33264
Open
alan-agius4 wants to merge 1 commit into
Open
fix(@angular/ssr): support server-side rendering configuration options#33264alan-agius4 wants to merge 1 commit into
alan-agius4 wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://ghub.bbstale.com/avatars/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new ServerRenderingOptions interface and updates the provideServerRendering function to accept these options, allowing configuration of the maximum response body size. The review feedback points out that maxResponseBodySize is marked as required in the interface despite having a documented default value of 1MB, and suggests making it optional to improve usability.
alan-agius4
force-pushed
the
fix/ssr-options
branch
2 times, most recently
from
6f5553b to
7a79b85
Compare
alan-agius4
added
the
action: review
JeanMeche
approved these changes
May 28, 2026
alan-agius4
removed
the
action: review
Introduce the ServerRenderingOptions interface to support configuring options such as maxResponseBodySize for server-side rendering. - Clean up overloads of provideServerRendering to use the ServerRenderingOptions interface instead of inline anonymous types. - Add an array-level type guard hasOptions to check for options arguments at runtime, allowing TypeScript to narrow the arguments union type automatically without the need for manual type assertions (casts). - Update the JSDocs for the provideServerRendering overloads to document parameter options and include clear examples.
alan-agius4
force-pushed
the
fix/ssr-options
branch
from
7a79b85 to
9b8e89d
Compare
alan-agius4
added
target: rc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce the ServerRenderingOptions interface to support configuring options such as maxResponseBodySize for server-side rendering.