Convert JavaZlib from byte arrays to NIO ByteBuffer#3981
Open
winnpixie wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reimplements the JavaZlib class. Previously, BungeeCord used
byte[]arrays that were copies of the content of a NettyByteBuf. This has performance and memory penalties. With these changes, JavaZlib will utilize the underlying NIOByteBuffer(s) that back aByteBuf. While this implementation still has its drawbacks (buffering is utilized to transfer data after Deflate/Inflate calls fromByteBuffer->ByteBuf), I believe this will lay the groundwork required for someone to take initiative in ensuring this code is performant.