fix: skip invalid repo-map tree-sitter queries#5138
Open
pragnyanramtha wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QueryErrorwhile running repo-map tag queriesMotivation
A bundled tags query can drift out of sync with the installed tree-sitter grammar. Julia files currently hit this path with
Invalid node type ... module, which aborts repo-map generation before Aider can answer the next prompt.Fixes #4867
Fixes #4888
Validation
.venv/bin/python -m pytest tests/basic/test_repomap.py::TestRepoMap::test_get_repo_map_skips_invalid_tree_sitter_query -q.venv/bin/python -m pytest tests/basic/test_repomap.py -q.venv/bin/pre-commit run --files aider/repomap.py tests/basic/test_repomap.pygit diff --checkhello.jlrepo-map smoke test now returnshello.jlinstead of raisingtree_sitter.QueryError