Skip to content

inspector: support inspecting HTTP/2 request and response bodies#60483

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RaisinTen:network-inspector-http2-request-response-data
Nov 4, 2025
Merged

inspector: support inspecting HTTP/2 request and response bodies#60483
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RaisinTen:network-inspector-http2-request-response-data

Conversation

@RaisinTen
Copy link
Copy Markdown
Member

@RaisinTen RaisinTen commented Oct 29, 2025

Now, we can track the request and response bodies of HTTP/2 calls through the Network tab of Chrome DevTools for Node.js.

Refs: #53946


Demo

demo.mov

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/inspector
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Oct 29, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 72.28916% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.55%. Comparing base (f46152f) to head (f67af83).
⚠️ Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/inspector/network_http2.js 72.28% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60483      +/-   ##
==========================================
- Coverage   88.58%   88.55%   -0.04%     
==========================================
  Files         704      704              
  Lines      207839   207922      +83     
  Branches    40051    40050       -1     
==========================================
+ Hits       184117   184124       +7     
- Misses      15791    15828      +37     
- Partials     7931     7970      +39     
Files with missing lines Coverage Δ
lib/internal/inspector/network_http2.js 87.73% <72.28%> (-7.21%) ⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread lib/internal/inspector/network_http2.js Outdated
@legendecas legendecas added the inspector Issues and PRs related to the V8 inspector protocol label Oct 29, 2025
Comment thread lib/internal/streams/readable.js Outdated
Comment thread lib/internal/inspector/network_http2.js
Signed-off-by: Darshan Sen <raisinten@gmail.com>
@RaisinTen RaisinTen force-pushed the network-inspector-http2-request-response-data branch from 6430e7f to f67af83 Compare November 1, 2025 14:54
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Member

@islandryu islandryu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2025
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator