src: implement util.types fast API calls#57819
Merged
Merged
Conversation
5e8ba0a to
e4b0c0a
Compare
e4b0c0a to
5770181
Compare
anonrig
requested changes
Apr 10, 2025
Member
anonrig
left a comment
There was a problem hiding this comment.
Can you add specific tests for each one of these calls to make sure these fast paths are triggered? Please take a look into the documentation:
An example can be found at
node/doc/contributing/adding-v8-fast-api.md
Line 212 in edf87b4
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57819 +/- ##
==========================================
- Coverage 90.23% 90.22% -0.01%
==========================================
Files 630 630
Lines 185245 185497 +252
Branches 36301 36376 +75
==========================================
+ Hits 167154 167372 +218
+ Misses 11006 10996 -10
- Partials 7085 7129 +44
🚀 New features to boost your workflow:
|
c74523f to
18a24b6
Compare
Member
Author
|
@anonrig thanks for the hint, I just added the test. I guess we could update the documentation to add the debug part as I did now. |
anonrig
reviewed
Apr 10, 2025
targos
reviewed
Apr 11, 2025
anonrig
approved these changes
Apr 12, 2025
All util.types.is##Type() calls are ported to the fast API. This improves the performance for multiple APIs such as: - util.inspect (and util.format and console methods respectively) - util.isDeepStrictEqual - assert.(not)deepEqual (including strict and partial mode) It will also improve any other API where these APIs are used.
f6eca05 to
1d00f22
Compare
jasnell
approved these changes
Apr 12, 2025
All util.types.is##Type() calls are ported to the fast API.
This improves the performance for multiple APIs such as:
Local benchmark