benchmark: Add NodeError and Error benchmark#43077
Closed
RafaelGSS wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Furthermore, I can go deeper into the analysis and share my thoughts here. |
mscdex
reviewed
May 12, 2022
Contributor
|
What is the purpose of |
7a0b11e to
f5ece4a
Compare
Member
Author
|
Well, lately I have had no time to investigate/improve how the A few insights to solve it can be found in: nodejs/undici#1203 (comment). |
Collaborator
Collaborator
19 tasks
Contributor
f5ece4a to
64fc8c1
Compare
Contributor
Contributor
|
Can you add a test, similarly as node/test/benchmark/test-benchmark-misc.js Lines 1 to 7 in 9e40df7 |
64fc8c1 to
df87435
Compare
Member
Author
Just did, I knew I was forgetting something. |
19 tasks
aduh95
approved these changes
May 26, 2022
While investigating
fetchperformance (nodejs/undici#1203 (comment)) I've found thatNodeErroris a bottleneck inWebStreams.I created this Pull Request to share the insights and help as I can to improve the
NodeErrorperformance. We can use this PR thread to discuss approaches to solve it.For reference, this is the benchmark result I'm getting:
*-cpu description: CPU product: AMD Ryzen 5 3500X 6-Core Processor vendor: Advanced Micro Devices [AMD] physical id: 2f bus info: cpu@0 version: AMD Ryzen 5 3500X 6-Core Processor serial: Unknown slot: AM4 size: 4030MHz capacity: 4100MHz width: 64 bits clock: 100MHzcc: @jasnell @mcollina