Skip to content

lib: replace validator and error#41678

Closed
VoltrexKeyva wants to merge 2 commits into
nodejs:masterfrom
VoltrexKeyva:replace-validator-and-error
Closed

lib: replace validator and error#41678
VoltrexKeyva wants to merge 2 commits into
nodejs:masterfrom
VoltrexKeyva:replace-validator-and-error

Conversation

@VoltrexKeyva
Copy link
Copy Markdown
Contributor

@VoltrexKeyva VoltrexKeyva commented Jan 24, 2022

Refs: #41660

@VoltrexKeyva VoltrexKeyva added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jan 24, 2022
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jan 24, 2022

Review requested:

  • @nodejs/crypto
  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 24, 2022
@VoltrexKeyva VoltrexKeyva force-pushed the replace-validator-and-error branch from 84b3363 to 80d1c46 Compare January 24, 2022 16:19
@targos
Copy link
Copy Markdown
Member

targos commented Jan 24, 2022

/cc @jasnell

@VoltrexKeyva VoltrexKeyva mentioned this pull request Jan 24, 2022
Closed
benjamingr
benjamingr approved these changes Jan 24, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good (semver major) change and it

@benjamingr
Copy link
Copy Markdown
Member

benjamingr commented Jan 24, 2022

I think since this has breakage potential probably good to ping the TSC on this too @nodejs/tsc

@VoltrexKeyva VoltrexKeyva force-pushed the replace-validator-and-error branch 2 times, most recently from 90f4bdb to 4909cdd Compare January 24, 2022 16:36
aduh95
aduh95 reviewed Jan 24, 2022
View reviewed changes
Comment thread doc/api/errors.md Outdated
@VoltrexKeyva VoltrexKeyva force-pushed the replace-validator-and-error branch 2 times, most recently from fd86a8c to fea8a26 Compare January 24, 2022 16:58
aduh95
aduh95 approved these changes Jan 24, 2022
View reviewed changes
Comment thread doc/api/deprecations.md
@VoltrexKeyva VoltrexKeyva force-pushed the replace-validator-and-error branch 4 times, most recently from 4d38054 to c42ae39 Compare January 24, 2022 23:21
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2022
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Ayase-252
Ayase-252 reviewed Jan 25, 2022
View reviewed changes
Comment thread test/parallel/test-performance-function.js
@VoltrexKeyva VoltrexKeyva force-pushed the replace-validator-and-error branch 2 times, most recently from 808c503 to 0c32513 Compare January 25, 2022 09:58
@VoltrexKeyva VoltrexKeyva added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2022
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
RaisinTen
RaisinTen requested changes Jan 26, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think timerify() should still accept functions as well as classes.

Comment thread test/parallel/test-performance-function.js
Comment thread lib/internal/validators.js
@VoltrexKeyva VoltrexKeyva force-pushed the replace-validator-and-error branch 2 times, most recently from 810575a to 2af3577 Compare February 2, 2022 03:32
aduh95
aduh95 reviewed Feb 2, 2022
View reviewed changes
Comment thread doc/api/deprecations.md Outdated
Comment thread doc/api/deprecations.md Outdated
Comment thread doc/api/deprecations.md Outdated
Comment thread lib/internal/errors.js Outdated
@VoltrexKeyva VoltrexKeyva force-pushed the replace-validator-and-error branch from f2fe3f3 to 8606e6b Compare February 3, 2022 23:41