Skip to content

fix jittery scrolling#40215

Closed
saltybuckets wants to merge 6 commits into
nodejs:mainfrom
saltybuckets:fix-scrolling
Closed

fix jittery scrolling#40215
saltybuckets wants to merge 6 commits into
nodejs:mainfrom
saltybuckets:fix-scrolling

Conversation

@saltybuckets
Copy link
Copy Markdown

@saltybuckets saltybuckets commented Sep 25, 2021 •
edited by aduh95
Loading

Subsystem: doc

This pr fixes the jittery scrolling behavior introduced in
#37301

Fixes: #40099
Refs: https://infrequently.org/2020/12/resize-resilient-deferred-rendering/

@saltybuckets
subsystem:doc
5322a0d 
This pr fixes the jittery scrolling behavior introduced in
nodejs#37301

fix:nodejs#40099
refs:https://infrequently.org/2020/12/resize-resilient-deferred-rendering/
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 25, 2021
aduh95
aduh95 reviewed Sep 26, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this. Can you please revert the unrelated stylistic changes? Also it'd be nice if the JavaScript code was using the same stylistic choices as the rest of the codebase – maybe you can put this to a separate .js file in doc/api_assets so the linter can autofix that for you.

@Trott
Copy link
Copy Markdown
Member

Trott commented Sep 27, 2021

@nodejs/website

@saltybuckets
Copy link
Copy Markdown
Author

saltybuckets commented Sep 27, 2021

@aduh95 done! 👍

@saltybuckets saltybuckets requested a review from aduh95 September 27, 2021 04:54
nschonni
nschonni reviewed Sep 27, 2021
View reviewed changes
Comment thread doc/template.html Outdated
<link rel="stylesheet" href="assets/style.css">
<link rel="stylesheet" href="assets/hljs.css">
<link rel="canonical" href="https://nodejs.org/api/__FILENAME__.html">
<script src="assets/script.js"></script>
Copy link
Copy Markdown
Member

@nschonni nschonni Sep 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add to the existing script?

Copy link
Copy Markdown
Author

@saltybuckets saltybuckets Sep 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aduh95 asked to move it to a different file

maybe you can put this to a separate .js file in doc/api_assets so the linter can autofix that for you.

aduh95
aduh95 reviewed Sep 27, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove this line:

node/.eslintignore

Line 9 in 8d83c47

doc/**/*.js

And then, run make lint-js-fix.

Comment thread doc/template.html Outdated
Comment thread doc/template.html Outdated
@saltybuckets saltybuckets requested a review from aduh95 September 28, 2021 18:14
aduh95
aduh95 reviewed Sep 28, 2021
View reviewed changes
Comment thread doc/template.html Outdated
Comment thread doc/api_assets/script.js Outdated
Comment thread doc/api_assets/script.js Outdated
@saltybuckets @aduh95
Apply suggestions from code review
a6e35c8 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@saltybuckets saltybuckets requested a review from aduh95 September 28, 2021 18:54
@saltybuckets
Copy link
Copy Markdown
Author

saltybuckets commented Oct 4, 2021

@nschonni can you review the changes pls since @aduh95 has been gone for 6 days

@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented Oct 5, 2021 •
edited
Loading

@Sanchitverma78 I understand it's frustrating when a PR gets stalled because of a lack of reviews, please also understand that most (all?) Node.js contributors are doing reviews on their spare time, so you have to understand that sometimes things takes time because of a lack of volunteers and different priorities.
It's of course OK for you to ask for reviews, you may ping me to ask me when I'll be available to review your PR, you may also ping other collaborators, but tagging me to at the third person feels a bit aggressive and unnecessary so please don't.