[Tests] no-cycles Add failing tests for commonjs imports #1517
Closed
soryy708 wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Coverage decreased by adding tests? Is it accidentally counting |
ljharb
force-pushed
the
cycles
branch
3 times, most recently
from
238fb4e to
50ef767
Compare
Member
|
I've rebased this and merged the first commit into master. |
ljharb
changed the title
no-cycles Add failing tests for commonjs imports
Member
|
@soryy708 are these tests no longer applicable, or did they come in via another PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #1056
This is expected to break the build, as at the moment "the infrastructure only registers import statements in dependencies, so cycles created by require within imported modules may not be detected.".