refactor: fix test import path inconsistency for docker-manager by Copilot · Pull Request #2975 · github/gh-aw-firewall

Copilot · 2026-05-12T00:52:38Z

Bug Fix

What was the bug?

Five src/services/* tests imported generateDockerCompose through ../docker-manager (a backward-compatibility barrel) while peer tests already imported directly from ../compose-generator. This created unnecessary API-surface inconsistency in the test suite.

How did you fix it?

Canonicalized import source in service tests
- Updated these files to import generateDockerCompose from ../compose-generator:
  - src/services/agent-environment-credentials.test.ts
  - src/services/agent-volumes.test.ts
  - src/services/agent-environment-runtime.test.ts
  - src/services/agent-environment-proxy.test.ts
  - src/services/agent-environment-options.test.ts
Aligned test suite conventions
- Service tests now consistently reference the canonical module rather than the compatibility barrel.

// Before
import { generateDockerCompose } from '../docker-manager';

// After
import { generateDockerCompose } from '../compose-generator';

Testing

Import-path-only change in tests; no production logic modified.

lpcox

Clean import path fix — changes 5 test files from docker-manager barrel to direct compose-generator import. Verified diff is surgical. Closes #2958.

lpcox · 2026-05-12T00:59:48Z

/copilot review

github-actions · 2026-05-12T01:01:48Z

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	87.89%	87.97%	📈 +0.08%
Statements	87.85%	87.92%	📈 +0.07%
Functions	83.51%	83.51%	➡️ +0.00%
Branches	79.79%	79.84%	📈 +0.05%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
`src/container-lifecycle.ts`	87.3% → 88.4% (+1.09%)	87.7% → 88.7% (+1.06%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

github-actions · 2026-05-12T01:02:45Z

🔬 Smoke Test: Copilot BYOK (Offline) Mode

Test	Result
GitHub MCP connectivity	❌ (401 - repo private/token scope)
GitHub.com HTTP connectivity	⚠️ (template vars not expanded)
File write/read	✅ (`smoke-test-copilot-byok-25706645849.txt` exists)
BYOK inference (api-proxy → api.githubcopilot.com)	✅

Running in BYOK offline mode (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com.

Overall: PARTIAL PASS — BYOK inference path confirmed working; GitHub MCP returned 401 (credential scope issue, not BYOK-related).

🔑 BYOK report filed by Smoke Copilot BYOK

github-actions · 2026-05-12T01:02:57Z

Smoke Test Results
❌ GitHub MCP (auth unavailable in sandbox)
✅ Playwright: github.com page title verified
✅ File Writing: test file created
✅ Bash Tool: file contents verified

Status: PARTIAL (3/4 tests passed)

💥 [THE END] — Illustrated by Smoke Claude

Copilot

Pull request overview

This PR standardizes generateDockerCompose imports in the src/services/* test suite by switching remaining tests from the backward-compatibility ../docker-manager barrel to the canonical ../compose-generator module, aligning import paths across peer tests.

Changes:

Updated 5 service test files to import generateDockerCompose from ../compose-generator.
Reduced reliance on the docker-manager compatibility barrel within the service test suite.

Show a summary per file

File	Description
src/services/agent-volumes.test.ts	Switch `generateDockerCompose` import to `../compose-generator`.
src/services/agent-environment-runtime.test.ts	Switch `generateDockerCompose` import to `../compose-generator`.
src/services/agent-environment-proxy.test.ts	Switch `generateDockerCompose` import to `../compose-generator`.
src/services/agent-environment-options.test.ts	Switch `generateDockerCompose` import to `../compose-generator`.
src/services/agent-environment-credentials.test.ts	Switch `generateDockerCompose` import to `../compose-generator`.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 5/5 changed files
Comments generated: 1

@@ -1,4 +1,4 @@
-import { generateDockerCompose } from '../docker-manager';
+import { generateDockerCompose } from '../compose-generator';


github-actions · 2026-05-12T01:03:42Z

🔬 Smoke Test Results

Test	Result
GitHub MCP connectivity	❌ 401 Bad credentials
GitHub.com HTTP	⚠️ Template vars not expanded
File write/read	✅ `/tmp/gh-aw/agent/smoke-test-copilot-25706645985.txt` confirmed

Overall: FAIL — GitHub MCP returned 401; template variables (${{ steps.smoke-data.outputs.* }}) were not substituted before agent invocation.

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-05-12T01:03:54Z

Smoke Test: FAIL

PRs: fix: add --ignore-scripts to security-guard Claude Code install; refactor: remove dead exports from export audit
✅ GitHub PR review/API; ❌ safeinputs-gh unavailable
✅ Playwright title; ❌ Tavily search unavailable
✅ file/bash; ⚠️ discussion skipped; ✅ build
Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

github-actions · 2026-05-12T01:04:58Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	1/1 passed	✅ PASS
Go	env	✅	1/1 passed	✅ PASS
Go	uuid	✅	1/1 passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	passed	✅ PASS
Node.js	execa	✅	passed	✅ PASS
Node.js	p-limit	✅	passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #2975 · ● 408.8K · ◷

github-actions · 2026-05-12T01:05:26Z

Smoke Test Results

Check	Result
Redis PING	❌ Connection timed out (`host.docker.internal:6379`)
PostgreSQL pg_isready	❌ No response (`host.docker.internal:5432`)
PostgreSQL SELECT 1	❌ No response

Overall: FAIL — Services are not reachable from the agent environment. Neither host.docker.internal nor 127.0.0.1 resolved to running service containers.

🔌 Service connectivity validated by Smoke Services

github-actions · 2026-05-12T01:06:42Z

🧪 Chroot Smoke Test Results

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.13	Python 3.12.3	❌
Node.js	v24.14.1	v20.20.2	❌
Go	go1.22.12	go1.22.12	✅

Result: FAILED — Python and Node.js versions differ between host and chroot. Go matches.

Tested by Smoke Chroot

Initial plan

8c63608

Copilot AI assigned Copilot and lpcox May 12, 2026

Copilot started work on behalf of lpcox May 12, 2026 00:52 View session

Copilot AI linked an issue May 12, 2026 that may be closed by this pull request

[Export Audit] Test import path inconsistency: 5 service tests use docker-manager barrel instead of compose-generator #2958

Closed

fix: align service tests to compose-generator import

f8f5368

Copilot AI changed the title ~~[WIP] Fix test import path inconsistency for docker-manager~~ Normalize service test imports to canonical compose-generator module May 12, 2026

Copilot finished work on behalf of lpcox May 12, 2026 00:55

Copilot AI requested a review from lpcox May 12, 2026 00:55

lpcox changed the title ~~Normalize service test imports to canonical compose-generator module~~ refactor: fix test import path inconsistency for docker-manager May 12, 2026

lpcox approved these changes May 12, 2026

View reviewed changes

lpcox closed this May 12, 2026

lpcox reopened this May 12, 2026

lpcox marked this pull request as ready for review May 12, 2026 01:00

lpcox requested a review from Mossaka as a code owner May 12, 2026 01:00

Copilot AI review requested due to automatic review settings May 12, 2026 01:00

Copilot started reviewing on behalf of lpcox May 12, 2026 01:01 View session

github-actions Bot mentioned this pull request May 12, 2026

[aw] Smoke OpenCode failed #2979

Closed

Copilot AI reviewed May 12, 2026

View reviewed changes

Comment thread src/services/agent-environment-proxy.test.ts

@@ -1,4 +1,4 @@

import { generateDockerCompose } from '../docker-manager';

import { generateDockerCompose } from '../compose-generator';

github-actions Bot added the build-test label May 12, 2026

github-actions Bot mentioned this pull request May 12, 2026

[aw] Smoke Gemini failed #2983

Closed

lpcox merged commit ac10c67 into main May 12, 2026
67 of 72 checks passed

lpcox deleted the copilot/fix-import-path-inconsistency branch May 12, 2026 01:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: fix test import path inconsistency for docker-manager#2975

refactor: fix test import path inconsistency for docker-manager#2975
lpcox merged 2 commits into
mainfrom
copilot/fix-import-path-inconsistency

Copilot AI commented May 12, 2026 •

edited

Loading

Uh oh!

lpcox left a comment

Uh oh!

lpcox commented May 12, 2026

Uh oh!

github-actions Bot commented May 12, 2026

Uh oh!

github-actions Bot commented May 12, 2026

Uh oh!

github-actions Bot commented May 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented May 12, 2026

Uh oh!

github-actions Bot commented May 12, 2026

Uh oh!

github-actions Bot commented May 12, 2026

Uh oh!

github-actions Bot commented May 12, 2026

Uh oh!

github-actions Bot commented May 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -1,4 +1,4 @@
		import { generateDockerCompose } from '../docker-manager';
		import { generateDockerCompose } from '../compose-generator';

Conversation

Copilot AI commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bug Fix

What was the bug?

How did you fix it?

Testing

Uh oh!

lpcox left a comment

Choose a reason for hiding this comment

Uh oh!

lpcox commented May 12, 2026

Uh oh!

github-actions Bot commented May 12, 2026

✅ Coverage Check Passed

Overall Coverage

Uh oh!

github-actions Bot commented May 12, 2026

🔬 Smoke Test: Copilot BYOK (Offline) Mode

Uh oh!

github-actions Bot commented May 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

github-actions Bot commented May 12, 2026

🔬 Smoke Test Results

Uh oh!

github-actions Bot commented May 12, 2026

Smoke Test: FAIL

Uh oh!

github-actions Bot commented May 12, 2026

🏗️ Build Test Suite Results

Uh oh!

github-actions Bot commented May 12, 2026

Smoke Test Results

Uh oh!

github-actions Bot commented May 12, 2026

🧪 Chroot Smoke Test Results

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 12, 2026 •

edited

Loading